Moodle
  1. Moodle
  2. MDL-36904

Clean up codechecker issues in assignment

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.5
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. Install latest version of codechecker plugin
      2. From the top of the Moodle installation run php -f local/codechecker/run.php mod/assign
      3. Verify there are not warnings or errors reported
      4. From the top of the Moodle installation run php -f local/codechecker/run.php admin/tool/assignmentupgrade
      5. Verify there are not warnings or errors reported
      6. Install unit tests from MDL-35413
      7. Run all unit tests for mod/assign
      8. Verify there are no failed unit tests
      Show
      Install latest version of codechecker plugin From the top of the Moodle installation run php -f local/codechecker/run.php mod/assign Verify there are not warnings or errors reported From the top of the Moodle installation run php -f local/codechecker/run.php admin/tool/assignmentupgrade Verify there are not warnings or errors reported Install unit tests from MDL-35413 Run all unit tests for mod/assign Verify there are no failed unit tests
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
      git@github.com:damyon/moodle.git
    • Pull Master Branch:
      MDL-36904-master

      Description

      This makes peer review/integrating patches easier if all the code in the assignment module is of the same standard.

      I want to do this all at once at the start of the 2.5dev cycle.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Damyon Wiese added a comment -

            1054 Errors
            1352 Warnings.

            Show
            Damyon Wiese added a comment - 1054 Errors 1352 Warnings.
            Hide
            Damyon Wiese added a comment - - edited

            0 Errors
            0 Warnings
            1 Powerball

            Show
            Damyon Wiese added a comment - - edited 0 Errors 0 Warnings 1 Powerball
            Hide
            Damyon Wiese added a comment -

            Setting MDL-35413 as a blocker for this issue because it contains the unit tests required to test this patch.

            Show
            Damyon Wiese added a comment - Setting MDL-35413 as a blocker for this issue because it contains the unit tests required to test this patch.
            Hide
            Damyon Wiese added a comment -

            Found an issue in testing.

            Show
            Damyon Wiese added a comment - Found an issue in testing.
            Hide
            Damyon Wiese added a comment -

            The issue I found (MDL-37030) was unrelated so re-sending this for integration.

            Show
            Damyon Wiese added a comment - The issue I found ( MDL-37030 ) was unrelated so re-sending this for integration.
            Hide
            Damyon Wiese added a comment -

            (Currently fixing some conflicts with latest master - will update the branch soon).

            Show
            Damyon Wiese added a comment - (Currently fixing some conflicts with latest master - will update the branch soon).
            Hide
            Damyon Wiese added a comment -

            Rebased and retested.

            Show
            Damyon Wiese added a comment - Rebased and retested.
            Hide
            Damyon Wiese added a comment -

            Rebased and retested.

            Show
            Damyon Wiese added a comment - Rebased and retested.
            Hide
            Damyon Wiese added a comment -

            rebased and retested.

            Show
            Damyon Wiese added a comment - rebased and retested.
            Hide
            Sam Hemelryk added a comment -

            Alrighty thanks Damyon this has been integrated now

            Show
            Sam Hemelryk added a comment - Alrighty thanks Damyon this has been integrated now
            Hide
            Jason Fowler added a comment -

            All tests passed nicely, thanks Damyon

            Show
            Jason Fowler added a comment - All tests passed nicely, thanks Damyon
            Hide
            Eloy Lafuente (stronk7) added a comment -

            And your fantastic code has met core, hope they become good friends for a long period.

            Closing, thanks!

            Show
            Eloy Lafuente (stronk7) added a comment - And your fantastic code has met core, hope they become good friends for a long period. Closing, thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: