Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3, 2.4
    • Fix Version/s: 2.3.4, 2.4.1
    • Component/s: Accessibility
    • Labels:
    • Testing Instructions:
      Hide
      1. View an assignment activity
      2. select 'View/grade all submissions' link
        Make sure the select grading actions has label (on top of the page).
      Show
      View an assignment activity select 'View/grade all submissions' link Make sure the select grading actions has label (on top of the page).
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Missing <label> for grading select options in assignment grading page.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            ankit_frenz Ankit Agarwal added a comment - - edited

            Hi Rosie,
            The patch looks good.
            But there are other accessibility issues around the code you are fixing(Attached screen). Please feel free to take care of that in this or a new issue.
            Also I am not sure if the "accesshide" class is needed in this case, might be good to leave the label visible. But feel free to ignore if you don't agree.

            Thanks

            Show
            ankit_frenz Ankit Agarwal added a comment - - edited Hi Rosie, The patch looks good. But there are other accessibility issues around the code you are fixing(Attached screen). Please feel free to take care of that in this or a new issue. Also I am not sure if the "accesshide" class is needed in this case, might be good to leave the label visible. But feel free to ignore if you don't agree. Thanks
            Hide
            rwijaya Rossiani Wijaya added a comment -

            Thanks ankit for catching the empty label string.

            I fixed the grading action label to be display.

            Patch has been updated.

            Show
            rwijaya Rossiani Wijaya added a comment - Thanks ankit for catching the empty label string. I fixed the grading action label to be display. Patch has been updated.
            Hide
            salvetore Michael de Raadt added a comment -

            This doesn't need to be peer reviewed again.

            Show
            salvetore Michael de Raadt added a comment - This doesn't need to be peer reviewed again.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Rosie, has been integrated now

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Rosie, has been integrated now
            Hide
            abgreeve Adrian Greeve added a comment -

            Tested on the 2.3 and master integration branches.
            There is now a label next to the grading actions select box.
            Test passed.

            Show
            abgreeve Adrian Greeve added a comment - Tested on the 2.3 and master integration branches. There is now a label next to the grading actions select box. Test passed.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now!

            Closing, ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now! Closing, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Jan/13