Moodle
  1. Moodle
  2. MDL-36908

Assignment Issues when making an empty submission

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.3.4, 2.4.1
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. Create an assignment in a course with at least 4 students
      2. Change the settings for the assignment so that "Require students click submit button" is enabled, "Online text" is enabled and "Submission comments" is enabled
      3. Login as a student and click add submission
      4. Do not enter any text and click "Save changes"
      5. Verify you stay on the submission page and see a warning "Nothing was submitted"
      6. Login as a different student and click add submission
      7. Enter some text and click "Save changes"
      8. Verify the changes are saved and the submission status is "Draft (not submitted)"
      9. Login as a teacher and change the assignment settings
      10. Change the settings for the assignment so that "Require students click submit button" to disabled
      11. Login as a different student and add a submission, do not enter any text and click "Save changes"
      12. Verify you stay on the submission page and see a warning "Nothing was submitted"
      13. Login as a different student and click add submission
      14. Enter some text and click "Save changes"
      15. Verify the changes are saved and the submission status is "Submitted for grading"
      16. Login as a teacher and view the assignment.
      17. Verify that the grading summary lists 1 assignment that requires grading.
      Show
      Create an assignment in a course with at least 4 students Change the settings for the assignment so that "Require students click submit button" is enabled, "Online text" is enabled and "Submission comments" is enabled Login as a student and click add submission Do not enter any text and click "Save changes" Verify you stay on the submission page and see a warning "Nothing was submitted" Login as a different student and click add submission Enter some text and click "Save changes" Verify the changes are saved and the submission status is "Draft (not submitted)" Login as a teacher and change the assignment settings Change the settings for the assignment so that "Require students click submit button" to disabled Login as a different student and add a submission, do not enter any text and click "Save changes" Verify you stay on the submission page and see a warning "Nothing was submitted" Login as a different student and click add submission Enter some text and click "Save changes" Verify the changes are saved and the submission status is "Submitted for grading" Login as a teacher and view the assignment. Verify that the grading summary lists 1 assignment that requires grading.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull Master Branch:
      MDL-36908-master
    • Rank:
      46443

      Description

      Some additional issues have been found with the changes introduced in MDL-35963.

      1. Attempting a submission with no files and then cancelling updates submission to "Submitted for grading"
      2. Attempting a submission with no files and "Require students click submit button" enabled takes you back to the submission summary page and not the edit submission page.

        Issue Links

          Activity

          Hide
          Damyon Wiese added a comment -

          Note for integrators: This is a nice fix to have - but without it the linked patch behaves no worse than the current 2.3 version.

          Show
          Damyon Wiese added a comment - Note for integrators: This is a nice fix to have - but without it the linked patch behaves no worse than the current 2.3 version.
          Hide
          Damyon Wiese added a comment -

          Found a bug.

          Show
          Damyon Wiese added a comment - Found a bug.
          Hide
          Damyon Wiese added a comment -

          Added test instructions to test the positive case.

          Show
          Damyon Wiese added a comment - Added test instructions to test the positive case.
          Hide
          Damyon Wiese added a comment -

          This is looks good to me now.

          Show
          Damyon Wiese added a comment - This is looks good to me now.
          Hide
          Sam Hemelryk added a comment -

          Thanks Damyon, this has been integrated now.
          MDL-36263 was integrated at the same time btw

          Show
          Sam Hemelryk added a comment - Thanks Damyon, this has been integrated now. MDL-36263 was integrated at the same time btw
          Hide
          Andrew Davis added a comment -

          Works as described. Passing.

          Show
          Andrew Davis added a comment - Works as described. Passing.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now!

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now! Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: