Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Usability
    • Labels:
    • Rank:
      46448

      Description

      Assignment grading icon issues

        Activity

        Hide
        Damyon Wiese added a comment -

        [Y] Syntax
        [-] Output
        [Y] Whitespace
        [-] Language
        [-] Databases
        [Y] Testing
        [-] Security
        [Y] Documentation
        [N] Git
        [Y] Sanity check

        There is a merge conflict with the latest master (theme/upgrade.txt).

        Can you rebase this and then this is ready.

        Everything looks good - tested on chrome, firefox and ie8.

        Show
        Damyon Wiese added a comment - [Y] Syntax [-] Output [Y] Whitespace [-] Language [-] Databases [Y] Testing [-] Security [Y] Documentation [N] Git [Y] Sanity check There is a merge conflict with the latest master (theme/upgrade.txt). Can you rebase this and then this is ready. Everything looks good - tested on chrome, firefox and ie8.
        Hide
        Frédéric Massart added a comment -

        Done! Thanks Damyon!

        Show
        Frédéric Massart added a comment - Done! Thanks Damyon!
        Hide
        Aparup Banerjee added a comment - - edited

        the original and the new icons changes are fine.. but do we want to align the tops of the two new icons?
        i think the Edit column's icons can be lifted to be aligned with the other icon's top

        i'll just try to do this now. (Fred had tried i heard)

        edit: this was just js not loading right which bumps up the edit icon. i had to purge caches (even with theme designer mode one )

        Show
        Aparup Banerjee added a comment - - edited the original and the new icons changes are fine.. but do we want to align the tops of the two new icons? i think the Edit column's icons can be lifted to be aligned with the other icon's top i'll just try to do this now. (Fred had tried i heard) edit: this was just js not loading right which bumps up the edit icon. i had to purge caches (even with theme designer mode one )
        Hide
        Aparup Banerjee added a comment -

        thanks, that's been integrated into master.

        Show
        Aparup Banerjee added a comment - thanks, that's been integrated into master.
        Hide
        Aparup Banerjee added a comment -

        passing

        Show
        Aparup Banerjee added a comment - passing
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Just in time for Moodle 2.4.0 release, thanks!

        Closing, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Just in time for Moodle 2.4.0 release, thanks! Closing, ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: