Moodle
  1. Moodle
  2. MDL-36933

Bump all versions, requires and dependencies near 2.4 release in master

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: General, Installation
    • Labels:
    • Testing Instructions:
      Hide

      1) TEST: Visually verify that all the changes in the patch point to the correct "TARGET" version and nothing else is changed. Note main version.php file is >= "TARGET".

      2) Upgrade from any previous 2.2.x, 2.3.x or 2.4dev version.

      3) TEST: In the plugins screen ALL the plugins are showing "to upgrade".

      4) TEST: All the target versions and all the dependencies show the "TARGET" version along the whole page.

      5) TEST: Run upgrade. Ends without error.

      6) TEST: To integrators, verify the "Check version.php files (master)" job in the integration server ends without error, that everything points to "TARGET" version and that the report does not include any "ERROR" looking to the generated "versions_check_set.txt" file in the workspace. Note some "WARN" can exist. But that's not relevant for this issue.

      Show
      1) TEST: Visually verify that all the changes in the patch point to the correct "TARGET" version and nothing else is changed. Note main version.php file is >= "TARGET". 2) Upgrade from any previous 2.2.x, 2.3.x or 2.4dev version. 3) TEST: In the plugins screen ALL the plugins are showing "to upgrade". 4) TEST: All the target versions and all the dependencies show the "TARGET" version along the whole page. 5) TEST: Run upgrade. Ends without error. 6) TEST: To integrators, verify the "Check version.php files (master)" job in the integration server ends without error, that everything points to "TARGET" version and that the report does not include any "ERROR" looking to the generated "versions_check_set.txt" file in the workspace. Note some "WARN" can exist. But that's not relevant for this issue.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      46472

      Description

      This task corresponds to point #3 of:

      http://docs.moodle.org/dev/Major_release_process#One_week_before

      And it's achieved in a semi-automated way with the "versions_check_set.sh" script available @ https://github.com/moodlehq/moodle-local_ci/blob/master/versions_check_set/versions_check_set.sh

      1) In a git, working, master site with the ci local plugin installed.

      2) Define and export all the env variables required by the script.

      • $WORKSPACE: Path to the directory where test reults will be sent (/tmp)
      • $phpcmd: Path to the PHP CLI executable (/usr/bin/php)
      • $gitdir: Directory containing git repo (the dirroot of the git, working site)
      • $setversion: 10digits (YYYYMMDD00) to set all versions to. Empty = not set

      3) Run it. With errors, they will be reported and fixing will be necessary. (look for ERROR in the $WORKSPACE/versions_check_set.txt file and/or check exit status of the script)

      4) Without errors, all the versions, requires and dependencies will be bumped.

      5) Commit

      6) Note that the main version file is NOT updated at all. One extra commit bumping it may be necessary.

      7) Run the checker again to verify that there are no errors and no more changes are performed.

      Note the checker is also run periodically by the ci server and also as part of the "remote_branch_checker", so normally all the version.php files should be under control.

      (This issue will be cloned for each major release).

      Ciao

        Issue Links

          Activity

          Hide
          Eloy Lafuente (stronk7) added a comment - - edited

          "TARGET" has been decided to be 2012112900 (for test instructions understanding).

          (1 day before rc1 packaging tomorrow and > than current 2012112700.01)

          Show
          Eloy Lafuente (stronk7) added a comment - - edited "TARGET" has been decided to be 2012112900 (for test instructions understanding). (1 day before rc1 packaging tomorrow and > than current 2012112700.01)
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Sending to integration, it should cause the version checker to start passing. 2 commits.

          Show
          Eloy Lafuente (stronk7) added a comment - Sending to integration, it should cause the version checker to start passing. 2 commits.
          Hide
          Dan Poltawski added a comment -

          Integrated, thanks Eloy!

          Show
          Dan Poltawski added a comment - Integrated, thanks Eloy!
          Hide
          Dan Poltawski added a comment -

          All looks good. Tested upgrade frm 2.3 just for good measure.

          Show
          Dan Poltawski added a comment - All looks good. Tested upgrade frm 2.3 just for good measure.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Y E S !

          Closing as fixed, many thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Y E S ! Closing as fixed, many thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: