Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36937

Typo in cache_store::supports_native_ttl prevents it from returning the correct value.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Caching
    • Labels:
    • Database:
      Microsoft SQL
    • Testing Instructions:
      Hide
      1. Log in as an admin
      2. Browse to settings > plugins > caching > configuration
      3. Add an instance of either memcache stores.
      4. Check when the instance is shown under store instance summaries that it has "ttl" in its supports list.
      Show
      Log in as an admin Browse to settings > plugins > caching > configuration Add an instance of either memcache stores. Check when the instance is shown under store instance summaries that it has "ttl" in its supports list.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      wip-MDL-36937-m24

      Description

      return $this::supports_data_guarantee() & self::SUPPORTS_NATIVE_TTL;

      is just plain wrong, should be:

      return $this::get_supported_features() & self::SUPPORTS_NATIVE_TTL;

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            samhemelryk Sam Hemelryk added a comment -

            Straight up for integration review in the hopes that perhaps this could still make it in.

            Show
            samhemelryk Sam Hemelryk added a comment - Straight up for integration review in the hopes that perhaps this could still make it in.
            Hide
            poltawski Dan Poltawski added a comment -

            Integrated, thanks Sam!

            Show
            poltawski Dan Poltawski added a comment - Integrated, thanks Sam!
            Hide
            poltawski Dan Poltawski added a comment -

            Tested during integration and passed.

            Show
            poltawski Dan Poltawski added a comment - Tested during integration and passed.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Y E S !

            Closing as fixed, many thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Y E S ! Closing as fixed, many thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  3/Dec/12