Moodle

Cache store add instance form validation doesn't handle errors well at all!

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 2.4
  • Fix Version/s: 2.4.1
  • Component/s: Caching
  • Labels:
  • Testing Instructions:
    Hide

    There is no real good way to test this in core presently as its unused.
    However the following can be done:

    1. Install XCache and enable it by giving it a positive xcache.var_size value.
    2. Install the XCache plugin from here https://github.com/samhemelryk/moodle-cachestore_xcache
    3. Log in as an admin
    4. Browse to Settings > Plugins > Caching > Configuration
    5. Add an XCache instance, give it a name that is not unique, and give it the prefix test.
    6. Check you get an error about the name not being unique when you try to submit.
    Show
    There is no real good way to test this in core presently as its unused. However the following can be done: Install XCache and enable it by giving it a positive xcache.var_size value. Install the XCache plugin from here https://github.com/samhemelryk/moodle-cachestore_xcache Log in as an admin Browse to Settings > Plugins > Caching > Configuration Add an XCache instance, give it a name that is not unique, and give it the prefix test. Check you get an error about the name not being unique when you try to submit.
  • Affected Branches:
    MOODLE_24_STABLE
  • Fixed Branches:
    MOODLE_24_STABLE
  • Pull from Repository:
  • Pull 2.4 Branch:
    wip-MDL-36939-m24
  • Pull 2.4 Diff URL:
  • Pull Master Branch:
    wip-MDL-36939-m25
  • Pull Master Diff URL:

Description

When a cache store instances configuration is changed and the form values validated the instance callback to handle validation isn't given the current errors and then overwrites the errors array as its result.
This means that duplicate names and such can get through validation and break a system if a cache store is being used that handles custom validation.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Sam Hemelryk added a comment -

Putting this straight up for integration review.

Show
Sam Hemelryk added a comment - Putting this straight up for integration review.
Hide
Permalink
Dan Poltawski added a comment -

Thanks Sam, i've integrated this now

Show
Dan Poltawski added a comment - Thanks Sam, i've integrated this now
Hide
Permalink
David Monllaó added a comment -

It passes; I see the not unique warning

Show
David Monllaó added a comment - It passes; I see the not unique warning
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now!

Closing, ciao

Show
Eloy Lafuente (stronk7) added a comment - Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now! Closing, ciao

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: