Moodle
  1. Moodle
  2. MDL-36943

available plugin notification by mail is incorrect

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.3, 2.4
    • Fix Version/s: 2.3.4, 2.4.1
    • Component/s: Administration
    • Labels:
    • Testing Instructions:
      Hide

      Testing difficulty: HARD (requires site upgrade and DB access)

      1. Install a recent 2.3 site. Make sure that cron.php IS NOT executed automatically to have control over that. Also, DO NOT click on "Check for updates" button during this test.
      2. At the Site administration ► Server ► Update notifications, enable updateautocheck and updatenotifybuilds and set updateminmaturity to Alpha
      3. Install the latest HotPot activity module from the Plugins directory.
      4. Run cron.php
      5. TEST: Make sure that no notification about the HotPot available update is sent.
      6. TEST: You should get the notification about 2.4 and 2.5dev update available with no repeated line (this is to test MDL-37003).
      7. Upgrade the site to the latest 2.4 patched with submitted patches (again, DO NOT click the Check for updates button during the upgrade).
      8. Execute the following SQL to force re-fetching data on the next cron:
        UPDATE mdl_config_plugins SET value=1 WHERE plugin = 'core_plugin' AND name='recentfetch';
        
      9. Run cron.php
      10. TEST: Make sure you again receive no notification about the HotPot available.
      Show
      Testing difficulty: HARD (requires site upgrade and DB access) Install a recent 2.3 site. Make sure that cron.php IS NOT executed automatically to have control over that. Also, DO NOT click on "Check for updates" button during this test. At the Site administration ► Server ► Update notifications, enable updateautocheck and updatenotifybuilds and set updateminmaturity to Alpha Install the latest HotPot activity module from the Plugins directory. Run cron.php TEST: Make sure that no notification about the HotPot available update is sent. TEST: You should get the notification about 2.4 and 2.5dev update available with no repeated line (this is to test MDL-37003 ). Upgrade the site to the latest 2.4 patched with submitted patches (again, DO NOT click the Check for updates button during the upgrade). Execute the following SQL to force re-fetching data on the next cron: UPDATE mdl_config_plugins SET value=1 WHERE plugin = 'core_plugin' AND name='recentfetch'; Run cron.php TEST: Make sure you again receive no notification about the HotPot available.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Rank:
      46484

      Description

      When I install a plugin, I receive an e-mail from Moodle that there is a new version available for the plugin. I receive this mail after the day the plugin is installed. However, the version mentioned in the e-mail is the same version that is installed on the server.

      the notifications page in Moodle don't show this information. it says that the Moodle code is up to date.

      I don't know if there is an duplicate bug of this problem. I couldn't find it.

        Issue Links

          Activity

          Hide
          Helen Foster added a comment -

          Mitchell, thanks for your report. I've added update notifications developer David as a watcher as hopefully he'll have some ideas!

          Show
          Helen Foster added a comment - Mitchell, thanks for your report. I've added update notifications developer David as a watcher as hopefully he'll have some ideas!
          Hide
          David Mudrak added a comment -

          Hi Mitchell. Can you tell me what plugin did you experience this with? Does it happen all the time you install some plugin? And what are your settings at Site administration ► Server ► Update notifications?

          Show
          David Mudrak added a comment - Hi Mitchell. Can you tell me what plugin did you experience this with? Does it happen all the time you install some plugin? And what are your settings at Site administration ► Server ► Update notifications?
          Hide
          Mitchell van Gerwen added a comment - - edited

          Hello David, thank you for your help.
          It happens on every plugin I have installed. The kind of plugin doesn't matter also.

          the plugins i got this issue is: progressbar block and aardvark theme and the grade exports plugin pdf document

          These are my settings in update notifications:

          updatetocheck is enabled
          updatematurity is set on stable
          updatenotifybuilds is also anabled

          Show
          Mitchell van Gerwen added a comment - - edited Hello David, thank you for your help. It happens on every plugin I have installed. The kind of plugin doesn't matter also. the plugins i got this issue is: progressbar block and aardvark theme and the grade exports plugin pdf document These are my settings in update notifications: updatetocheck is enabled updatematurity is set on stable updatenotifybuilds is also anabled
          Hide
          David Mudrak added a comment -

          OK, I can reproduce the issue now and I already know what is causing it. Working on the fix. Thanks for letting us know!

          Show
          David Mudrak added a comment - OK, I can reproduce the issue now and I already know what is causing it. Working on the fix. Thanks for letting us know!
          Hide
          Mitchell van Gerwen added a comment -

          No problem, glad I can help

          Show
          Mitchell van Gerwen added a comment - No problem, glad I can help
          Hide
          David Mudrak added a comment -

          Submitting for integration. Note that I fixed MDL-37003 in this patchset, too. See my comment there.

          DEAR INTEGRATORS,

          please apply both patches (in order) to 2.3, 2.4 and master branch. They are supposed to apply cleanly at all three branches.

          Show
          David Mudrak added a comment - Submitting for integration. Note that I fixed MDL-37003 in this patchset, too. See my comment there. DEAR INTEGRATORS, please apply both patches (in order) to 2.3, 2.4 and master branch. They are supposed to apply cleanly at all three branches.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (23, 24 & master), thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (23, 24 & master), thanks!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Passed, thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Passed, thanks!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          This has landed upstream, closing, thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - This has landed upstream, closing, thanks!
          Hide
          Mitchell van Gerwen added a comment -

          Thank you for your hard works folks!

          Show
          Mitchell van Gerwen added a comment - Thank you for your hard works folks!

            People

            • Votes:
              2 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: