[MDL-36950] Automatic update deployment does not support sites behind a proxy - Moodle Tracker

XML

Word

Printable

Testing Instructions:
Hide

Testing difficulty: MEDIUM (requires a site behind a proxy)

Prepare a site behind a proxy and make sure the proxy is defined at Site administration ► Server ► HTTP.

TEST: Make sure that you are able to update a plugin via "Install this update" button.

TEST (optional but preferred): Use a monitoring tool to make sure that the traffic really goes thru the proxy (I was using http://www.charlesproxy.com/ during the development)
Show
Testing difficulty: MEDIUM (requires a site behind a proxy) Prepare a site behind a proxy and make sure the proxy is defined at Site administration ► Server ► HTTP. TEST: Make sure that you are able to update a plugin via "Install this update" button. TEST (optional but preferred): Use a monitoring tool to make sure that the traffic really goes thru the proxy (I was using http://www.charlesproxy.com/ during the development)
Affected Branches:
MOODLE_24_STABLE
Fixed Branches:
MOODLE_24_STABLE
Pull from Repository:
git://github.com/mudrd8mz/moodle.git
Pull Master Branch:
~~MDL-36950~~-updates-proxy

Shortly, proxy related settings ($CFG->proxyhost and friends) are not passed to mdeploy.php. They should be.

Discovered while testing

MDL-36973 curl class doesn't respect is_proxybypass

has a non-specific relationship to

MDL-35238 Automatic plugin update deployment

is blocked by

MDL-36903 Download pre-check for plugin ZIP packages

Participants:: Dan Poltawski, David Mudrák (@mudrd8mz), Eloy Lafuente (stronk7)

Component watchers:: Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze