Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36950

Automatic update deployment does not support sites behind a proxy

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Administration
    • Labels:
    • Testing Instructions:
      Hide

      Testing difficulty: MEDIUM (requires a site behind a proxy)

      1. Prepare a site behind a proxy and make sure the proxy is defined at Site administration ► Server ► HTTP.
      2. TEST: Make sure that you are able to update a plugin via "Install this update" button.
      3. TEST (optional but preferred): Use a monitoring tool to make sure that the traffic really goes thru the proxy (I was using http://www.charlesproxy.com/ during the development)
      Show
      Testing difficulty: MEDIUM (requires a site behind a proxy) Prepare a site behind a proxy and make sure the proxy is defined at Site administration ► Server ► HTTP. TEST: Make sure that you are able to update a plugin via "Install this update" button. TEST (optional but preferred): Use a monitoring tool to make sure that the traffic really goes thru the proxy (I was using http://www.charlesproxy.com/ during the development)
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-36950-updates-proxy

      Description

      Shortly, proxy related settings ($CFG->proxyhost and friends) are not passed to mdeploy.php. They should be.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              mudrd8mz David Mudrák added a comment -

              DEAR INTEGRATORS,

              Please integrate MDL-36903 first. This branch is built on top of it.

              Show
              mudrd8mz David Mudrák added a comment - DEAR INTEGRATORS, Please integrate MDL-36903 first. This branch is built on top of it.
              Hide
              mudrd8mz David Mudrák added a comment -

              The following changes since commit 333048e06b19c06828ea3d30f63ecc5a4a0088df:
               
                MDL-36903 Add a link to Moodle documentation from mdeploy error pages (2012-11-30 16:09:58 +0100)
               
              are available in the git repository at:
                git://github.com/mudrd8mz/moodle.git MDL-36950-updates-proxy
               
              David Mudrák (2):
                    MDL-36950 Make mdeploy.php accept proxy related settings
                    MDL-36950 Pass the Moodle proxy setting to the mdeploy.php utility
               
               lib/pluginlib.php |   22 ++++++++++++++++++++++
               mdeploy.php       |   24 ++++++++++++++++++++++++
               2 files changed, 46 insertions(+), 0 deletions(-)

              Show
              mudrd8mz David Mudrák added a comment - The following changes since commit 333048e06b19c06828ea3d30f63ecc5a4a0088df:   MDL-36903 Add a link to Moodle documentation from mdeploy error pages (2012-11-30 16:09:58 +0100)   are available in the git repository at: git://github.com/mudrd8mz/moodle.git MDL-36950-updates-proxy   David Mudrák (2): MDL-36950 Make mdeploy.php accept proxy related settings MDL-36950 Pass the Moodle proxy setting to the mdeploy.php utility   lib/pluginlib.php | 22 ++++++++++++++++++++++ mdeploy.php | 24 ++++++++++++++++++++++++ 2 files changed, 46 insertions(+), 0 deletions(-)
              Hide
              poltawski Dan Poltawski added a comment -

              We need an issue for the is_proxybypass() problem, else we'll never fix it

              Show
              poltawski Dan Poltawski added a comment - We need an issue for the is_proxybypass() problem, else we'll never fix it
              Hide
              poltawski Dan Poltawski added a comment -

              I have created MDL-36973 for that.

              Show
              poltawski Dan Poltawski added a comment - I have created MDL-36973 for that.
              Hide
              poltawski Dan Poltawski added a comment -

              I've integrated this now David.

              Show
              poltawski Dan Poltawski added a comment - I've integrated this now David.
              Hide
              poltawski Dan Poltawski added a comment -

              Tested during integration, and looks good!

              Show
              poltawski Dan Poltawski added a comment - Tested during integration, and looks good!
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Just in time for Moodle 2.4.0 release, thanks!

              Closing, ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Just in time for Moodle 2.4.0 release, thanks! Closing, ciao

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    3/Dec/12