Moodle
  1. Moodle
  2. MDL-36966

in Assignment activity, student who edits a submission after it has been graded will show as having been 'graded by' herself in the Feedback Summary

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.3, 2.4
    • Fix Version/s: 2.3.4, 2.4.1
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide

      1. Create an assignment activity with feedback settings (comments/file/offline grading) set to NO,YES is set just for file submission setting and the rest of submission types are set to NO and 'Require students click submit button' set to No as well
      2. Have a student account submit a file
      3. Grade the submission as a teacher
      4. View the grade as a student and click the 'edit my submissions' button
      5. Click 'Save changes'

      The 'Graded by' details in the Feedback summary in the student's page will show the teacher's name still

      Show
      1. Create an assignment activity with feedback settings (comments/file/offline grading) set to NO,YES is set just for file submission setting and the rest of submission types are set to NO and 'Require students click submit button' set to No as well 2. Have a student account submit a file 3. Grade the submission as a teacher 4. View the grade as a student and click the 'edit my submissions' button 5. Click 'Save changes' The 'Graded by' details in the Feedback summary in the student's page will show the teacher's name still
    • Workaround:
      Hide

      none

      Show
      none
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-36966-master
    • Rank:
      46506

      Description

      Student who edits a submission after it has been graded will show as
      having graded themselves

      Steps to replicate:

      1. Create an assignment activity with feedback settings (comments/file/offline grading) set to NO,YES is set just for file submission setting and the rest of submission types are set to NO and 'Require students click submit button' set to No as well
      2. Have a student account submit a file
      3. Grade the submission as a teacher
      4. View the grade as a student and click the 'edit my submissions' button
      5. Click 'Save changes'

      The 'Graded by' details in the Feedback summary in the student's page will now show the student's name instead of the teacher's

        Activity

        Hide
        Damyon Wiese added a comment - - edited

        Thanks for the patch Raymond:

        Peer review checklist

        [Y] Syntax
        [-] Output
        [Y] Whitespace
        [-] Language
        [-] Databases
        [Y] Testing
        [-] Security
        [-] Documentation
        [N] Git
        [Y] Sanity check

        I had to ammend the commit message. It is ready for integration now. I tested it on master and verified that the functionality is correct.

        Cheers - Damyon

        Show
        Damyon Wiese added a comment - - edited Thanks for the patch Raymond: Peer review checklist [Y] Syntax [-] Output [Y] Whitespace [-] Language [-] Databases [Y] Testing [-] Security [-] Documentation [N] Git [Y] Sanity check I had to ammend the commit message. It is ready for integration now. I tested it on master and verified that the functionality is correct. Cheers - Damyon
        Hide
        Damyon Wiese added a comment -

        Backported and tested on 23.

        Show
        Damyon Wiese added a comment - Backported and tested on 23.
        Hide
        Damyon Wiese added a comment -

        Thanks Raymond - sending for integration review.

        Show
        Damyon Wiese added a comment - Thanks Raymond - sending for integration review.
        Hide
        Sam Hemelryk added a comment -

        Thanks Raymond, this has been integrated now.

        Show
        Sam Hemelryk added a comment - Thanks Raymond, this has been integrated now.
        Hide
        Sam Hemelryk added a comment -

        Tested and passed during integration review.

        Show
        Sam Hemelryk added a comment - Tested and passed during integration review.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Did you know that your awesome changes are the last ones landing to CVS?

        After 11 years, 2 months and 8 days... it's ended, died, closed, kaputt. Big thanks to it, has served us really well.

        Closing this as fixed, many thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Did you know that your awesome changes are the last ones landing to CVS? After 11 years, 2 months and 8 days... it's ended, died, closed, kaputt. Big thanks to it, has served us really well. Closing this as fixed, many thanks!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: