Moodle
  1. Moodle
  2. MDL-36984

Assignment module should redirect after form submissions

    Details

    • Story Points (Obsolete):
      13
    • Sprint:
      FRONTEND Sprint 7

      Description

      After a student edits or saves a submission the view submission page is rendered directly without a redirect. This allows the possibility of resubmitting the form by using the browser refresh button or shortcut-key (e.g., F5). It also leaves the URL in the address bar set to

      {wwwroot}

      /mod/assign/view.php with no parameters which can cause confusion for users who bookmark the address, which when visited gives a required_param missing error. Redirecting the user after form submission ensures that the form cannot be resubmitted with a browser refresh and ensures that the URL is a valid URL for bookmarking.

      It would be ideal if a grader were redirect after submitting a grade for a student for the same reasons listed above.

        Gliffy Diagrams

          Activity

          Hide
          Damyon Wiese added a comment -

          Hi Sam,

          Thanks for reporting this issue. This should be fine to fix for student submissions, for graders it will require storing some information in MUC and so will be a bit more work (And only possible in 2.4+).

          I've put this on the backlog.

          Regards, Damyon

          Show
          Damyon Wiese added a comment - Hi Sam, Thanks for reporting this issue. This should be fine to fix for student submissions, for graders it will require storing some information in MUC and so will be a bit more work (And only possible in 2.4+). I've put this on the backlog. Regards, Damyon
          Hide
          Damyon Wiese added a comment -

          This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue.

          For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

          Show
          Damyon Wiese added a comment - This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue. For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment
          Hide
          moodle.com added a comment -

          This appears to be fixed for students, but not for markers.

          Show
          moodle.com added a comment - This appears to be fixed for students, but not for markers.
          Hide
          Jason Fowler added a comment -

          This hasn't been back ported to 2.4 because the awesome redirect feature that Damyon has introduced wasn't in 2.4.

          Show
          Jason Fowler added a comment - This hasn't been back ported to 2.4 because the awesome redirect feature that Damyon has introduced wasn't in 2.4.
          Hide
          Damyon Wiese added a comment -

          [Y] Syntax
          [Y] Whitespace
          [Y] Output
          [-] Language
          [-] Databases
          [Y] Testing (instructions and automated tests)
          [-] Security
          [-] Documentation
          [Y] Git
          [-] Third party code
          [Y] Sanity check

          Looks good +1 from me (and no backport to 2.4 - too risky).

          Show
          Damyon Wiese added a comment - [Y] Syntax [Y] Whitespace [Y] Output [-] Language [-] Databases [Y] Testing (instructions and automated tests) [-] Security [-] Documentation [Y] Git [-] Third party code [Y] Sanity check Looks good +1 from me (and no backport to 2.4 - too risky).
          Hide
          Sam Hemelryk added a comment -

          Thanks Jason this has been integrated now.

          Show
          Sam Hemelryk added a comment - Thanks Jason this has been integrated now.
          Hide
          Frédéric Massart added a comment -

          Passing, thanks.

          Show
          Frédéric Massart added a comment - Passing, thanks.
          Hide
          Damyon Wiese added a comment -

          Twas the week before Christmas,
          And all though HQ
          Devs were scrambling to finish peer review.
          They sent all their issues,
          and rushed out the door -
          "To the beach!" someone heard them roar!

          This issue has been released upstream. Thanks!

          Show
          Damyon Wiese added a comment - Twas the week before Christmas, And all though HQ Devs were scrambling to finish peer review. They sent all their issues, and rushed out the door - "To the beach!" someone heard them roar! This issue has been released upstream. Thanks!

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Agile