Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36991

Conditional activity restrictions should be displayed as a list

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Conditional activities
    • Labels:
    • Testing Instructions:
      Hide

      A) create new course
      1. add a Page activity with two conditions: date set to the future and course grade set to more than 50%
      2. add another Page with only one condition: date set to the future
      3. add another one with only one condition (date set to the future), and this time, set it to not display at all until the condition is met.

      B) Look at the conditions in the editing teacher role, verify that:
      1. the first Page shows a bullet list of conditions.
      2. the second Page shows only a single condition (no list).
      3. the third Page also shows only a single condition and has the text 'Restricted (not visible)' or whatever that is to indicate that it isn't shown to students.

      C) Log in with a student account or switch role to Student
      1. the first Page should be a list of conditions
      2. the second Page should show only a single condition (no list).
      3. The third page should not show at all

      Note: the strings displayed to students and editing teachers will probably be slightly different, but the rendering of the conditional activity lists should be the same.

      Show
      A) create new course 1. add a Page activity with two conditions: date set to the future and course grade set to more than 50% 2. add another Page with only one condition: date set to the future 3. add another one with only one condition (date set to the future), and this time, set it to not display at all until the condition is met. B) Look at the conditions in the editing teacher role, verify that: 1. the first Page shows a bullet list of conditions. 2. the second Page shows only a single condition (no list). 3. the third Page also shows only a single condition and has the text 'Restricted (not visible)' or whatever that is to indicate that it isn't shown to students. C) Log in with a student account or switch role to Student 1. the first Page should be a list of conditions 2. the second Page should show only a single condition (no list). 3. The third page should not show at all Note: the strings displayed to students and editing teachers will probably be slightly different, but the rendering of the conditional activity lists should be the same.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
      MDL-36991-master

      Description

      conditional activity restrictions are listed as a paragraph with several strong tags separating each activity. this should probably be converted to a list for readability and semantics. Here's an example of the code that's output:

      <div class="availabilityinfo ">Restricted: 'Not available until the activity <strong>Expert Domain Activity on Theology</strong> is marked complete. Not available until the activity <strong>Expert Domains (Theology) upload link</strong> is marked complete. Not available until the activity <strong>Father Zakaria Botros (forum)</strong> is marked complete. Not available until the activity <strong>Foundations of the Faith (Wiki)</strong> is marked complete.'</div>
      

      Something like this would be easier to understand:

      <div class="availabilityinfo">Restricted:  Not available until the activity/ies:
      <ul class="requiredactivities">
      <li>Expert Domain Activity on Theology</li>
      <li>Expert Domains (Theology) upload link</li>
      <li>Father Zakaria Botros (forum)</li>
      <li>Foundations of the Faith (Wiki)</li>
      </ul>
      is/are marked completed.
      </div>
      

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    14/May/13