Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.5
    • Component/s: Course
    • Labels:
    • Testing Instructions:
      Hide

      Test 1:

      1. Create an empty site
      2. Make sure admin can see 'Add course' button on front page (this is fixed in MDL-38592)
      3. Set up course requests: Site Administration -> Courses -> Course requests, add permission 'moodle/course:request' to some user who can not create courses.
      4. Create several courses in Miscellaneous category, ensure all simple actions are where they were before: When manager browses category he can see 'Add course' button, proper user can see 'Request course' button, in top category admin can see 'Courses pending approval' button.
      5. Set language to a RTL language (hebrew) - repeat the previous steps in this test and look for RTL issues.

      Test 2 big site:

      1. You need a site with many courses and categories
      2. You may want to reduce the $CFG->coursesperpage so pagination is displayed more often
      3. Browse all pages listed here and make sure there are no errors:
        http://docs.moodle.org/dev/Courses_lists_upgrade_to_2.5#Pages_that_are_affected_by_the_new_renderer_functions

      Test 3 MNET:

      1. Enable MNet, configure two hosts to see each other
      2. make sure you have a student enrolled in some courses on both servers, synchronise enrollments
      3. apply patch suggested in comments in MDL-37027, otherwise list of remote hosts will not be shown at all
      4. as a student login to server1
      5. make sure student can see on the front page the list of his own courses and remote courses form server 2
      6. make sure when student jumps to server2 he can see the server1 on the front page (as a remote host)

      Don't forget to remove the patch from MDL-37027

      Show
      Test 1: Create an empty site Make sure admin can see 'Add course' button on front page (this is fixed in MDL-38592 ) Set up course requests: Site Administration -> Courses -> Course requests, add permission 'moodle/course:request' to some user who can not create courses. Create several courses in Miscellaneous category, ensure all simple actions are where they were before: When manager browses category he can see 'Add course' button, proper user can see 'Request course' button, in top category admin can see 'Courses pending approval' button. Set language to a RTL language (hebrew) - repeat the previous steps in this test and look for RTL issues. Test 2 big site: You need a site with many courses and categories You may want to reduce the $CFG->coursesperpage so pagination is displayed more often Browse all pages listed here and make sure there are no errors: http://docs.moodle.org/dev/Courses_lists_upgrade_to_2.5#Pages_that_are_affected_by_the_new_renderer_functions Test 3 MNET: Enable MNet, configure two hosts to see each other make sure you have a student enrolled in some courses on both servers, synchronise enrollments apply patch suggested in comments in MDL-37027 , otherwise list of remote hosts will not be shown at all as a student login to server1 make sure student can see on the front page the list of his own courses and remote courses form server 2 make sure when student jumps to server2 he can see the server1 on the front page (as a remote host) Don't forget to remove the patch from MDL-37027
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
      wip-MDL-37009-master
    • Rank:
      46548

      Description

      Output course listings throughout the site using renderers.

      Functions that will be deprecated:

      print_course()
      print_my_moodle()
      print_remote_course()
      print_remote_host()
      print_course_search()

      get_course_category_tree()
      print_whole_category_list()
      print_courses()

      See documentation for upgrade in: http://docs.moodle.org/dev/Courses_lists_upgrade_to_2.5

      1. available_courses.png
        114 kB
      2. categories_only_list_on_frontpage.png
        44 kB
      3. combo_list_on_frontpage.png
        82 kB
      4. course_enrol.png
        85 kB
      5. course_info.png
        81 kB
      6. search_results.png
        115 kB
      7. tagged_courses_(coursesperpage_is_set_to_5).png
        121 kB
      8. x_category_view.png
        86 kB
      9. y_category_view_clicked_on_view_more.png
        93 kB

        Issue Links

          Activity

          Hide
          Marina Glancy added a comment -

          Created an issue MDL-37027 about not displaying of list of hosts. Code changes in this issue related to print_remote_host() are impossible to test until it is resolved

          Show
          Marina Glancy added a comment - Created an issue MDL-37027 about not displaying of list of hosts. Code changes in this issue related to print_remote_host() are impossible to test until it is resolved
          Hide
          Marina Glancy added a comment -

          TO INTEGRATORS: master only

          Show
          Marina Glancy added a comment - TO INTEGRATORS: master only
          Hide
          Marina Glancy added a comment -

          Hi Andrew
          this is the current state of the course listings refactoring
          it is far from finished yet. For example course search results and frontpage 'my courses' still go through different renderers but they all will go eventually through core_course_renderer::render_coursecat_renderable (lol, "render"x3)

          Anyway, try the following: add to the frontpage all three types of courses listings. Create several categories and courses in them. View frontpage and /course/index.php. You can try that on master and on this branch.

          I will still add a lot of things, like pagination and availability to receive list of courses/categories sorted by something different than sortorder. Also render_coursecat_renderable should not load the children of collapsed categories...

          But if you can start looking at html+css+js it will be great

          Show
          Marina Glancy added a comment - Hi Andrew this is the current state of the course listings refactoring it is far from finished yet. For example course search results and frontpage 'my courses' still go through different renderers but they all will go eventually through core_course_renderer::render_coursecat_renderable (lol, "render"x3) Anyway, try the following: add to the frontpage all three types of courses listings. Create several categories and courses in them. View frontpage and /course/index.php. You can try that on master and on this branch. I will still add a lot of things, like pagination and availability to receive list of courses/categories sorted by something different than sortorder. Also render_coursecat_renderable should not load the children of collapsed categories... But if you can start looking at html+css+js it will be great
          Hide
          Marina Glancy added a comment -

          Added screenshots of listings in standard theme

          Show
          Marina Glancy added a comment - Added screenshots of listings in standard theme
          Hide
          Marina Glancy added a comment -

          I added a commit transforming /course/info.php from popup into normal page. Since it is now the same width, I changed differences in layouts for coursebox inside courses list and by itself because

          Show
          Marina Glancy added a comment - I added a commit transforming /course/info.php from popup into normal page. Since it is now the same width, I changed differences in layouts for coursebox inside courses list and by itself because
          Hide
          Damyon Wiese added a comment -

          Hi Marina,

          This patch looks like a good improvement. It is currently breaking the behat tests though (and David is flat out getting the QA tests done). I'm going to have to get you to make this patch work with the behat tests before we can integrate it.

          Note: There are currently also a few non-related behat failures that David is working on (I'll get the issue number and post it here for you).

          I'll also post you the log from my behat test.

          Thanks, Damyon

          Show
          Damyon Wiese added a comment - Hi Marina, This patch looks like a good improvement. It is currently breaking the behat tests though (and David is flat out getting the QA tests done). I'm going to have to get you to make this patch work with the behat tests before we can integrate it. Note: There are currently also a few non-related behat failures that David is working on (I'll get the issue number and post it here for you). I'll also post you the log from my behat test. Thanks, Damyon
          Hide
          Damyon Wiese added a comment -
          Show
          Damyon Wiese added a comment - Behat log: http://pastebin.com/5AhM4rzs
          Hide
          Damyon Wiese added a comment -

          Davids issue is MDL-38823 - once his fix is integrated all the behat tests should pass cleanly.

          Show
          Damyon Wiese added a comment - Davids issue is MDL-38823 - once his fix is integrated all the behat tests should pass cleanly.
          Hide
          Damyon Wiese added a comment -

          Reopening - feel free to submit again when Behat is sorted out.

          Show
          Damyon Wiese added a comment - Reopening - feel free to submit again when Behat is sorted out.
          Hide
          CiBoT added a comment -

          Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

          Show
          CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Note we need this (and its blocker MDL-38823) solved asap, because the chain of issues blocked by this is getting tremendous.

          Show
          Eloy Lafuente (stronk7) added a comment - Note we need this (and its blocker MDL-38823 ) solved asap, because the chain of issues blocked by this is getting tremendous.
          Hide
          Damyon Wiese added a comment -

          Behat has been sorted and re-running this patch now does not give errors for me (yay).

          Show
          Damyon Wiese added a comment - Behat has been sorted and re-running this patch now does not give errors for me (yay).
          Hide
          Damyon Wiese added a comment -

          Thanks Marina,

          Sorry for the red herring with behat - this does not look like it breaks any behat tests. I have integrated this to master now (added one fix for a typo in the key for a new lang string).

          Show
          Damyon Wiese added a comment - Thanks Marina, Sorry for the red herring with behat - this does not look like it breaks any behat tests. I have integrated this to master now (added one fix for a typo in the key for a new lang string).
          Hide
          Damyon Wiese added a comment -

          Thanks Marina,

          Followed the test instructions and found no errors.

          Test passed!

          Show
          Damyon Wiese added a comment - Thanks Marina, Followed the test instructions and found no errors. Test passed!
          Hide
          Dan Poltawski added a comment -

          Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking.

          line 1289 of \lib\changes.php: call to debugging()
          line 281 of \lib\are.php: call to moodleform->detectMissingThanks()
          line 202 of \lib\now.php: call to moodleform->_is_poor_form()
          line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

          Show
          Dan Poltawski added a comment - Did you remember to call thankDevelopers() for 'this_weeks_work'? Defaulting to PARAM_SHODDY thanking. line 1289 of \lib\changes.php: call to debugging() line 281 of \lib\are.php: call to moodleform->detectMissingThanks() line 202 of \lib\now.php: call to moodleform->_is_poor_form() line 73 of \course\upstream.php: call to moodleform->forgetingToThank()

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: