Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4.1
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      Test pre-requisites

      • A course with some students enrolled.
      • Important - A manager for the course.

      Test steps

      1. Log in as the manager (this won't work with an administrator - MDL-37026)
      2. Go to the participants page.
      3. There should be an edit icon next to the heading 'All participants' in the middle of the page.
        • Make sure that it is the round edit icon (not a pencil) and that it is an appropriate size.
      4. At the bottom of the page there should be a help icon next to the label 'With selected users...'.
        • Ensure that there is some padding between the help icon and the text.
      5. Change the 'current role' select box to 'teacher' or 'student'.
        • Check that the edit icon in the same location as step 3 is the same.
      Show
      Test pre-requisites A course with some students enrolled. Important - A manager for the course. Test steps Log in as the manager (this won't work with an administrator - MDL-37026 ) Go to the participants page. There should be an edit icon next to the heading 'All participants' in the middle of the page. Make sure that it is the round edit icon (not a pencil) and that it is an appropriate size. At the bottom of the page there should be a help icon next to the label 'With selected users...'. Ensure that there is some padding between the help icon and the text. Change the 'current role' select box to 'teacher' or 'student'. Check that the edit icon in the same location as step 3 is the same.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-37011
    • Rank:
      46550

      Description

      The edit icon next to the heading is incorrect and misaligned.
      The help icon at the bottom needs more padding.

        Issue Links

          Activity

          Hide
          Damyon Wiese added a comment -

          Peer review checklist:

          [N] Syntax - user/index.php line 491 is longer than 132 chars
          [Y] Output
          [Y] Whitespace
          [Y] Language
          [-] Databases
          [N] Testing - The editing icon does not appear for students (Step 5).
          [-] Security
          [-] Documentation
          [Y] Git
          [Y] Sanity check

          Hi Adrian, just found some tiny things to fix up.

          Thanks - Damyon

          Show
          Damyon Wiese added a comment - Peer review checklist: [N] Syntax - user/index.php line 491 is longer than 132 chars [Y] Output [Y] Whitespace [Y] Language [-] Databases [N] Testing - The editing icon does not appear for students (Step 5). [-] Security [-] Documentation [Y] Git [Y] Sanity check Hi Adrian, just found some tiny things to fix up. Thanks - Damyon
          Hide
          Adrian Greeve added a comment -

          Thanks for the review Damyon.

          • I've split line 491 into two lines.
          • I've updated the testing instructions to be clearer.

          Submitting for integration review.

          Show
          Adrian Greeve added a comment - Thanks for the review Damyon. I've split line 491 into two lines. I've updated the testing instructions to be clearer. Submitting for integration review.
          Hide
          Damyon Wiese added a comment -

          This looks fine to me. Thanks Adrian.

          Show
          Damyon Wiese added a comment - This looks fine to me. Thanks Adrian.
          Hide
          Sam Hemelryk added a comment -

          Thanks Adrian, this has been integrated now.

          Show
          Sam Hemelryk added a comment - Thanks Adrian, this has been integrated now.
          Hide
          Jason Fowler added a comment -

          Nice work Adrian, all good

          Show
          Jason Fowler added a comment - Nice work Adrian, all good
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now!

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now! Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: