Moodle
  1. Moodle
  2. MDL-37017

Short names of courses on My Moodle page

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4.1
    • Component/s: My home
    • Labels:
    • Testing Instructions:
      Hide

      Test 1

      1. Log in as student who is enrolled in few courses
      2. Go to My Home page
      3. Make sure you can see full name of course

      Test 2

      1. Log in as student who is enrolled in remote course (MNET)
      2. Go to My Home page
      3. Make sure course name is shortname followed by hostname
      Show
      Test 1 Log in as student who is enrolled in few courses Go to My Home page Make sure you can see full name of course Test 2 Log in as student who is enrolled in remote course (MNET) Go to My Home page Make sure course name is shortname followed by hostname
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      wip-mdl-37017

      Description

      In version 2.3 and earlier there were displayed long names of courses on My Moodle page. After upgrading to 2.4 there are short names, which are confusing to users.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Rajesh Taneja added a comment -

            Thanks for reporting this.

            I've put that on the backlog.

            In the meantime feel free to help us work on this issue. If you are able to provide a patch or links to your Git repository branch, please add a patch label so we will spot it.

            Show
            Rajesh Taneja added a comment - Thanks for reporting this. I've put that on the backlog. In the meantime feel free to help us work on this issue. If you are able to provide a patch or links to your Git repository branch, please add a patch label so we will spot it.
            Hide
            Rajesh Taneja added a comment -

            Course name visible on My Home page was full name of course. This is only valid for local courses. For remote courses we show shortname with hostname. Refer course/lib.php - print_overview()

            Show
            Rajesh Taneja added a comment - Course name visible on My Home page was full name of course. This is only valid for local courses. For remote courses we show shortname with hostname. Refer course/lib.php - print_overview()
            Hide
            Lukas Mizoch added a comment -

            Hello Rajesh, thanks for fix, I tried it and it works great.

            Show
            Lukas Mizoch added a comment - Hello Rajesh, thanks for fix, I tried it and it works great.
            Hide
            Rajesh Taneja added a comment -

            Thanks for testing this Lukáš.

            Show
            Rajesh Taneja added a comment - Thanks for testing this Lukáš.
            Hide
            Damyon Wiese added a comment - - edited

            Peer Review Checklist:

            [N->Y] Syntax - -This line is too long and should be split into multiple lines. - Fixed
            [Y] Output
            [Y] Whitespace
            [Y] Language
            [-] Databases
            [Y] Testing - (But will need updating based on comments below)
            [-] Security
            [-] Documentation
            [Y] Git
            [N->Y] Sanity check - You are now showing the fullname for local courses and the shortname followed by the hostname for remote courses. I think they should both be fullname as the shortname can be very un-descriptive for students. - Resolved, this should be shortname (hostname) for remote courses.

            Thanks Raj - just a couple of minor things to fix.

            Show
            Damyon Wiese added a comment - - edited Peer Review Checklist: [N->Y] Syntax - -This line is too long and should be split into multiple lines. - Fixed [Y] Output [Y] Whitespace [Y] Language [-] Databases [Y] Testing - (But will need updating based on comments below) [-] Security [-] Documentation [Y] Git [N->Y] Sanity check - You are now showing the fullname for local courses and the shortname followed by the hostname for remote courses. I think they should both be fullname as the shortname can be very un-descriptive for students. - Resolved, this should be shortname (hostname) for remote courses. Thanks Raj - just a couple of minor things to fix.
            Hide
            Rajesh Taneja added a comment -

            Thanks for the review Damyon,

            I agree shortname should be fullname followed by hostname. But for consistency sake I left it that way.
            I have created another commit for master to display full name of remote course. But not sure if this should be backported.
            If you think this is fine, I will change testing instructions.

            Show
            Rajesh Taneja added a comment - Thanks for the review Damyon, I agree shortname should be fullname followed by hostname. But for consistency sake I left it that way. I have created another commit for master to display full name of remote course. But not sure if this should be backported. If you think this is fine, I will change testing instructions.
            Hide
            Damyon Wiese added a comment -

            Thanks Raj, when I looked at the linked patch I misread it - the old behaviour had shortname (hostname) for remote courses so we should keep it that way.

            The testing instructions are fine in that case and your updated branches fix the long line issue.

            This is ready for integration review.

            Show
            Damyon Wiese added a comment - Thanks Raj, when I looked at the linked patch I misread it - the old behaviour had shortname (hostname) for remote courses so we should keep it that way. The testing instructions are fine in that case and your updated branches fix the long line issue. This is ready for integration review.
            Hide
            Rajesh Taneja added a comment -

            Thanks Damyon.

            Show
            Rajesh Taneja added a comment - Thanks Damyon.
            Hide
            Sam Hemelryk added a comment -

            Thanks Raj, this has been integrated now

            Show
            Sam Hemelryk added a comment - Thanks Raj, this has been integrated now
            Hide
            David Monllaó added a comment -

            It passes. Tested in master with an mnet connection to a MOODLE_23_STABLE

            Show
            David Monllaó added a comment - It passes. Tested in master with an mnet connection to a MOODLE_23_STABLE
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now!

            Closing, ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Many thanks for your effort, the whole Moodle Community will be enjoying your great solutions starting now! Closing, ciao
            Hide
            Stephen Bloomer added a comment -

            It's good to see the fix is in 2.4.1. do we have any ideas as to when 2.4.1 will be released?

            Show
            Stephen Bloomer added a comment - It's good to see the fix is in 2.4.1. do we have any ideas as to when 2.4.1 will be released?
            Hide
            Helen Foster added a comment -

            Hi Stephen,

            You can find out when 2.4.1 is due to be released by checking the general release calendar in http://docs.moodle.org/dev/Releases

            However the fix for this issue is available now if you upgrade to the latest 2.4+ weekly.

            Show
            Helen Foster added a comment - Hi Stephen, You can find out when 2.4.1 is due to be released by checking the general release calendar in http://docs.moodle.org/dev/Releases However the fix for this issue is available now if you upgrade to the latest 2.4+ weekly.

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: