Moodle
  1. Moodle
  2. MDL-37030

Assignment: download all submissions fails for group assignment with online text.

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Major Major
        • Resolution: Fixed
        • Affects Version/s: 2.4
        • Fix Version/s: 2.4.2
        • Component/s: Assignment
        • Labels:
        • Testing Instructions:
          Hide
          1. Create an assignment in a course with no groups
          2. Settings:
            "Blind Marking" set to Yes
            "Students submit in groups" set to Yes
            "Online text" set to Yes
            "Feedback files" set to Yes
          3. Login as a student and make a submission with an image.
          4. Login as a teacher and choose download all submissions (From the drop down above the grading table).
          5. Verify the zip downloaded is valid and contains one image and one html file for each student.
          6. Unzip the files to a folder and open one of the html files - the image should display correctly.
          7. Edit the html file (change some text) and create a new zip containing the html file and the image for one student.
          8. As a teacher choose "Upload multiple feedback files in a zip" from the drop down menu above the grading table.
          9. Upload the newly created zip file.
          10. Confirm the upload
          11. Verify the student received the edited html file as a feedback file.
          Show
          Create an assignment in a course with no groups Settings: "Blind Marking" set to Yes "Students submit in groups" set to Yes "Online text" set to Yes "Feedback files" set to Yes Login as a student and make a submission with an image. Login as a teacher and choose download all submissions (From the drop down above the grading table). Verify the zip downloaded is valid and contains one image and one html file for each student. Unzip the files to a folder and open one of the html files - the image should display correctly. Edit the html file (change some text) and create a new zip containing the html file and the image for one student. As a teacher choose "Upload multiple feedback files in a zip" from the drop down menu above the grading table. Upload the newly created zip file. Confirm the upload Verify the student received the edited html file as a feedback file.
        • Affected Branches:
          MOODLE_24_STABLE
        • Fixed Branches:
          MOODLE_24_STABLE
        • Pull from Repository:
        • Pull Master Branch:
          MDL-37030-master
        • Pull Master Diff URL:

          Description

          The onlinetext submission plugin should not be prefixing the files (they will be prefixed by the assignment before they are added to the zip).

            Gliffy Diagrams

              Issue Links

              Testing discovered

              Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-35413 Implement Unit tests for mod_assign

              • Minor - Minor loss of function where workaround is possible
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                Damyon Wiese added a comment -

                This change moves the rewriting of pluginfile urls from the subplugins to the assign class. This ensured this rewriting is done consistently and will match the prefixing which is added to the names of the files in the exported zip. I also had to add a parameter to the get_files function in the assign_plugin class because it did not have enough information to do the correct prefixing when using group assignments with blind marking.

                Tested on master.

                Show
                Damyon Wiese added a comment - This change moves the rewriting of pluginfile urls from the subplugins to the assign class. This ensured this rewriting is done consistently and will match the prefixing which is added to the names of the files in the exported zip. I also had to add a parameter to the get_files function in the assign_plugin class because it did not have enough information to do the correct prefixing when using group assignments with blind marking. Tested on master.
                Hide
                Permalink
                Dan Poltawski added a comment -

                Hi Damyon,

                Shouldn't this be fixed on the stables too?

                Show
                Dan Poltawski added a comment - Hi Damyon, Shouldn't this be fixed on the stables too?
                Hide
                Permalink
                Damyon Wiese added a comment -

                The bug exists but doesn't break anything on 2.3 - this is only required on 2.4 and 2.5 (because group assignment triggers the bug).

                Show
                Damyon Wiese added a comment - The bug exists but doesn't break anything on 2.3 - this is only required on 2.4 and 2.5 (because group assignment triggers the bug).
                Hide
                Permalink
                Sam Hemelryk added a comment -

                Thanks Damyon, this has been integrated now.

                Show
                Sam Hemelryk added a comment - Thanks Damyon, this has been integrated now.
                Hide
                Permalink
                Rossiani Wijaya added a comment -

                This works great.

                Tested for 2.4 and master.

                Test passed.

                Show
                Rossiani Wijaya added a comment - This works great. Tested for 2.4 and master. Test passed.
                Hide
                Permalink
                Dan Poltawski added a comment -

                Hurray! We did it! Thanks to all the reporters, testers, user and watchers for a bumper week of Moodling!

                Show
                Dan Poltawski added a comment - Hurray! We did it! Thanks to all the reporters, testers, user and watchers for a bumper week of Moodling!
                Hide
                Permalink
                Eloy Lafuente (stronk7) added a comment -

                Side note: Plz, when changing STABLE branches like this, don't forget to:

                • Avoid modifying the API unless absolutely necessary (I assume this issues was).
                • Require documentation in upgrade.txt / release docs / moodle docs.

                Changes like this seem to make life really unpleasant to developers, source:

                https://moodle.org/mod/forum/discuss.php?d=224265

                Ciao

                Show
                Eloy Lafuente (stronk7) added a comment - Side note: Plz, when changing STABLE branches like this, don't forget to: Avoid modifying the API unless absolutely necessary (I assume this issues was). Require documentation in upgrade.txt / release docs / moodle docs. Changes like this seem to make life really unpleasant to developers, source: https://moodle.org/mod/forum/discuss.php?d=224265 Ciao

                  People

                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    5 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: