Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37034

Category Settings Node has no proper key name

    Details

    • Testing Instructions:
      Hide

      There are no visible ramifications of this change.
      Best we can do is test the navigation still functions in the correct spot.

      1. Log in as an admin
      2. Navigate to the course overview
      3. Turn editing on
      4. Edit a category
      5. Check things don't break.
      Show
      There are no visible ramifications of this change. Best we can do is test the navigation still functions in the correct spot. Log in as an admin Navigate to the course overview Turn editing on Edit a category Check things don't break.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-37034-CategoryNavigationKey

      Description

      When editing a category, the category settings navigation node does not have a properly named key.

      Replication steps:

      1. Log in as admin
      2. Navigate to Course Overview
      3. Turn Editing On
      4. Edit a category
      5. View var dump of $PAGE->settingsnav

      Expected result: The category settings navigation node should have an appropriately named key

      Actual result: The key is set to 0

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            salvetore Michael de Raadt added a comment -

            Hi, Andrew.

            Sam should triage this issue fully soon.

            I thought I should note, though, that this is a very well reported issue. Thanks.

            Show
            salvetore Michael de Raadt added a comment - Hi, Andrew. Sam should triage this issue fully soon. I thought I should note, though, that this is a very well reported issue. Thanks.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Hi Andrew,

            Thank you for reporting the issue and providing a fix for it. Most excellent.
            I've looked at the patch and it is spot on, I'll put this up for integration in just a sec.

            Many thanks
            Sam

            Show
            samhemelryk Sam Hemelryk added a comment - Hi Andrew, Thank you for reporting the issue and providing a fix for it. Most excellent. I've looked at the patch and it is spot on, I'll put this up for integration in just a sec. Many thanks Sam
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Integrators please cherry-pick to 23 and 24 as well.

            Show
            samhemelryk Sam Hemelryk added a comment - Integrators please cherry-pick to 23 and 24 as well.
            Hide
            poltawski Dan Poltawski added a comment -

            I've integrated this now (master, 24, 23) thanks guys.

            Show
            poltawski Dan Poltawski added a comment - I've integrated this now (master, 24, 23) thanks guys.
            Hide
            phalacee Jason Fowler added a comment -

            All good Sam

            Show
            phalacee Jason Fowler added a comment - All good Sam
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Changes are now upstream, thanks for your collaboration!

            If you are going to have any celebration next days, enjoy with your gang, if not, too!

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Changes are now upstream, thanks for your collaboration! If you are going to have any celebration next days, enjoy with your gang, if not, too! Ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Jan/13