Moodle

"Download all submissions" gives blank page when no submissions

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.4
  • Fix Version/s: 2.4.1
  • Component/s: Assignment
  • Labels:
  • Testing Instructions:
    Hide

    To test the patch:

    1. Create an assignment (mod_assign) which accepts file submissions
    2. Click on "download all submissions"
    3. Confirm that you see a message saying "Nothing has been submitted for this assignment"
    4. Make a submission to the assignment
    5. Click on "download all submissions" again
    6. Confirm that you get a zip file containing the submission
    Show
    To test the patch: Create an assignment (mod_assign) which accepts file submissions Click on "download all submissions" Confirm that you see a message saying "Nothing has been submitted for this assignment" Make a submission to the assignment Click on "download all submissions" again Confirm that you get a zip file containing the submission
  • Affected Branches:
    MOODLE_24_STABLE
  • Fixed Branches:
    MOODLE_24_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    MDL-37037-master
  • Pull Master Diff URL:

Description

When trying to download all assignments for an assignment where there are no submissions, the user sees a completely blank page. I would expect to either:

  • see a message explaining that there are no submissions
  • receive an empty zip file

To reproduce:

  1. Create an assignment (mod_assign) which accepts file submissions
  2. Click on "download all submissions"
  3. You should see a blank page
  4. Make a submission to the assignment
  5. Click on "download all submissions" again
  6. You should get a zip file containing the submission

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Damyon Wiese added a comment -

Thanks for reporting this.

I've put that on the backlog.

I think the best solution might be not to apply any filters if there are no submissions. This way it will still remember your filters when jumping between offline and online assignments.

  • Damyon
Show
Damyon Wiese added a comment - Thanks for reporting this. I've put that on the backlog. I think the best solution might be not to apply any filters if there are no submissions. This way it will still remember your filters when jumping between offline and online assignments. Damyon
Hide
Permalink
Damyon Wiese added a comment -

Sorry - that comment was for a different bug.

Thanks for reporting this bug too - I think a notice (not an error) saying there are no submissions might be the best solution here.

Show
Damyon Wiese added a comment - Sorry - that comment was for a different bug. Thanks for reporting this bug too - I think a notice (not an error) saying there are no submissions might be the best solution here.
Hide
Permalink
Michael Aherne added a comment -

Thanks, Damyon. I've created a patch for this.

Show
Michael Aherne added a comment - Thanks, Damyon. I've created a patch for this.
Hide
Permalink
Damyon Wiese added a comment -

Thanks Michael for the patch.

Peer review checklist:

[Y] Syntax
[Y] Output
[Y] Whitespace
[Y] Language
[-] Databases
[Y] Testing
[-] Security
[-] Documentation
[Y] Git
[Y] Sanity check

Everything was good with the patch - I added another commit on top of this change though just to make the control flow of the function a bit easier to read and to add a continue button to take you back to the grading page.

Thanks, sending for integration review.

Show
Damyon Wiese added a comment - Thanks Michael for the patch. Peer review checklist: [Y] Syntax [Y] Output [Y] Whitespace [Y] Language [-] Databases [Y] Testing [-] Security [-] Documentation [Y] Git [Y] Sanity check Everything was good with the patch - I added another commit on top of this change though just to make the control flow of the function a bit easier to read and to add a continue button to take you back to the grading page. Thanks, sending for integration review.
Hide
Permalink
Michael Aherne added a comment -

Thanks, Damyon. It's much better with the continue button!

Show
Michael Aherne added a comment - Thanks, Damyon. It's much better with the continue button!
Hide
Permalink
Dan Poltawski added a comment -

Thanks Michael/Damyon.

I've integrated this to master (and cherry picked to 2.4)

Show
Dan Poltawski added a comment - Thanks Michael/Damyon. I've integrated this to master (and cherry picked to 2.4)
Hide
Permalink
Dan Poltawski added a comment -

It works

Show
Dan Poltawski added a comment - It works
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Did you know that your awesome changes are the last ones landing to CVS?

After 11 years, 2 months and 8 days... it's ended, died, closed, kaputt. Big thanks to it, has served us really well.

Closing this as fixed, many thanks!

Show
Eloy Lafuente (stronk7) added a comment - Did you know that your awesome changes are the last ones landing to CVS? After 11 years, 2 months and 8 days... it's ended, died, closed, kaputt. Big thanks to it, has served us really well. Closing this as fixed, many thanks!

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: