Details

    • Testing Instructions:
      Hide

      Prerequisite

      1. Install new moodle site, or remove all courses and categories from your current moodle installation.

      Test 1

      1. Assign user as course creator at system
      2. Login as user
      3. Click home -> courses or Settings -> Site administration -> Courses -> Add/edit courses
      4. Make sure there is only one "Add a new course" button.

      Test 2

      1. Login as admin
      2. Click home -> courses or Settings -> Site administration -> Courses -> Add/edit courses (with turn editing off)
      3. Make sure there is only one "Add a new course" button.
      Show
      Prerequisite Install new moodle site, or remove all courses and categories from your current moodle installation. Test 1 Assign user as course creator at system Login as user Click home -> courses or Settings -> Site administration -> Courses -> Add/edit courses Make sure there is only one "Add a new course" button. Test 2 Login as admin Click home -> courses or Settings -> Site administration -> Courses -> Add/edit courses (with turn editing off) Make sure there is only one "Add a new course" button.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull Master Branch:
      wip-mdl-37062

      Description

      Clean 2.4 site
      Assign user as course creator at system
      Login as user
      Add/edit courses
      An extra Add a course button is present
      Tested IE9/Firefox

        Gliffy Diagrams

          Activity

          Hide
          Mary Cooch added a comment -

          This is also the case for an administrator too.

          Show
          Mary Cooch added a comment - This is also the case for an administrator too.
          Hide
          Rajesh Taneja added a comment -

          Thanks for reporting this Ray.

          I've put that on the backlog.

          In the meantime feel free to help us work on this issue. If you are able to provide a patch or links to your Git repository branch, please add a patch label so we will spot it.

          Show
          Rajesh Taneja added a comment - Thanks for reporting this Ray. I've put that on the backlog. In the meantime feel free to help us work on this issue. If you are able to provide a patch or links to your Git repository branch, please add a patch label so we will spot it.
          Show
          Robert Boloc added a comment - patch for this bug: https://github.com/robertboloc/moodle/compare/MOODLE_24_STABLE...%23MDL-37062-2.4
          Hide
          Helen Foster added a comment -

          Robert, thanks for your patch. I have added the patch label to this issue.

          Show
          Helen Foster added a comment - Robert, thanks for your patch. I have added the patch label to this issue.
          Hide
          Robert Boloc added a comment -

          Thank you! This bug is also present in the 2.3 version, I created a diferent patch branch, but the fix is basically the same https://github.com/robertboloc/moodle/compare/MOODLE_23_STABLE...%23MDL-37062-2.3

          Show
          Robert Boloc added a comment - Thank you! This bug is also present in the 2.3 version, I created a diferent patch branch, but the fix is basically the same https://github.com/robertboloc/moodle/compare/MOODLE_23_STABLE...%23MDL-37062-2.3
          Hide
          Rajesh Taneja added a comment -

          Thanks Robert.

          Show
          Rajesh Taneja added a comment - Thanks Robert.
          Hide
          Rajesh Taneja added a comment -

          Thanks for the patch Robert,

          There were few minor things with patch, so I re-wrote it.

          Show
          Rajesh Taneja added a comment - Thanks for the patch Robert, There were few minor things with patch, so I re-wrote it.
          Hide
          Damyon Wiese added a comment -

          Thanks Raj - I thought about whether removing the code that prints the "Add a new course" button from the print_courses function would be cleaner - but that would require changes in a few more places, so your patch looks good.

          [Y] Syntax
          [Y] Output
          [Y] Whitespace
          [-] Language
          [-] Databases
          [Y] Testing
          [-] Security
          [-] Documentation
          [Y] Git
          [Y] Sanity check

          Can you just change the issue type to bug as this is really a bug not an improvement (and you have provided backport branches)?

          Thumbs up from me.

          Show
          Damyon Wiese added a comment - Thanks Raj - I thought about whether removing the code that prints the "Add a new course" button from the print_courses function would be cleaner - but that would require changes in a few more places, so your patch looks good. [Y] Syntax [Y] Output [Y] Whitespace [-] Language [-] Databases [Y] Testing [-] Security [-] Documentation [Y] Git [Y] Sanity check Can you just change the issue type to bug as this is really a bug not an improvement (and you have provided backport branches)? Thumbs up from me.
          Hide
          Damyon Wiese added a comment -

          Actually I just spottted a typo in your commit message: It says MDl-37062 instead of MDL-37062 (capital L). Can you fix that too?

          Thanks, Damyon

          Show
          Damyon Wiese added a comment - Actually I just spottted a typo in your commit message: It says MDl-37062 instead of MDL-37062 (capital L). Can you fix that too? Thanks, Damyon
          Hide
          Rajesh Taneja added a comment -

          Thanks Damyon,

          I have changed type to bug and modified commit message. Pushing it for integration review.

          Show
          Rajesh Taneja added a comment - Thanks Damyon, I have changed type to bug and modified commit message. Pushing it for integration review.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (23, 24 & master), thanks!

          Side note: Always try to put "cheap" conditions before "expensive" ones. In this case it does not matter much, but is a good habit (the boolean vs the capability).

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (23, 24 & master), thanks! Side note: Always try to put "cheap" conditions before "expensive" ones. In this case it does not matter much, but is a good habit (the boolean vs the capability).
          Hide
          David Monllaó added a comment -

          It passes, works as expected

          Show
          David Monllaó added a comment - It passes, works as expected
          Hide
          Dan Poltawski added a comment -

          Hurray! We did it! Thanks to all the reporters, testers, user and watchers for a bumper week of Moodling!

          Show
          Dan Poltawski added a comment - Hurray! We did it! Thanks to all the reporters, testers, user and watchers for a bumper week of Moodling!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: