Jean-Michel, in your role as master of all things import/export, would you mind taking a look at this change? Thanks.

I am about to add testing instructions.

If all is OK, I will backport to stable branches.

Seems ok to me, thanks.

Hello Tim,
Sure. Will look at this.

Hello Tim,
Results of the review
In fact Tim's branch fix a lot of separate issues in the learnwise format wich was badly broken (is it still used ? Nobody seems to report the problems)

• this format wasn't accepting xml files because it missed the needed method FIXED
• this format produced numerous notices: Undefined offset: 1 because the foreach ($optionlist as $option) loop was trying to process empty choices FIXED
• As all other formats after Moodle 2.0 migration the import was dying with an Error writing to database because answers and feedbacks were strings and not arrays so the answerformat and feedbackformat values were missing when writing to database FIXED
• finally as explained in MDL-36212 there was a problem with the use of get_html_translation_table(HTML_ENTITIES); in the unhtmlentities function with certain php versions. I have been unable to replicate the problem but as Petr says it is OK and he is a lot more qualified than me on textlib use, consider as FIXED

The only remaining bit I saw is the use of a hardcoded string in line 134, but unfortunately search reveals other such hardcoded strings in some other formats (examview, webct, missing word, xhtml). So maybe it's better open a new tracker issue ?

But I think we can consider learnwise format as fixed and running. I hope someone is using it and Tim's work will be usefull

Sorry, I forgot to start peer review before writting my comments !

Next step of the workflow : finishing peer review !

Sorry I forgot to report a typo in the lang file plugidnname_help for pluginname_help this is why the help icon is not displayed.
I think you will need to change version after correction ?

Thanks Jean-Michel. Submitting for integration now.

To INTEGRATORS: Please cherry-pick to 2.4.

About the version number thing. You are right that if you change a string / JS / CSS in a contrib plug-in, then you have to change the version number. You don't have to do that with fixes that are to be integrated into Moodle core, because they increase the main version number for each weekly release.

Thanks Tim, all looked good and has been integrated now.

Thanks for fixing this Tim,

Was able to import learnwise format file in question bank (original and modified learnwise-example.xml)

And your fantastic code has met core, hope they become good friends for a long period.

Closing, thanks!