Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.5
    • Component/s: Course
    • Labels:
    • Testing Instructions:
      Hide

      There are just minor changes to the produced HTML (mostly in CSS), so basically the test is to ensure that everything is displayed as it was before.

      1. Create a course in topics or weeks format with enabled groups and activity completion
      2. Add groups and grouppings to the course
      3. Create several sections and several activities, make sure you have among activities:
        • Activity available only in one of the groups
        • Activity conditionally available (i.e. time based or completion based, etc.)
        • Activity conditionally available that should be displayed to students grayed-out
        • Activity with manual completion
        • Activity with automatic completion
        • Label and/or other activity without URLs
        • Glossary or other activity not supporting group mode
        • Activity with subtypes (i.e. mod_assignment)
      4. View the course as a teacher (both in view and edit mode) and as a student, make sure it looks the same as in master branch
      5. Make sure teacher can move modules in both JS enabled and disabled modes
      6. Make sure teacher can drag and drop file into course (in edit mode)
      7. Make sure student can change/view completion status
      1. Create course in social format
      2. Add some activities, make sure they are displayed correctly in social activities block
      1. In front page settings check the "Include a topic section" checkbox (numsections)
      2. Add site main menu block on the front page
      3. Add activities to the site main menu block and to the front page
      4. Make sure they are displayed correctly to both teacher (view/edit mode) and student

      Please re-test MDL-36808, MDL-35884, MDL-37015, MDL-30899, MDL-36736 because their changes were manually picked into renderer during rebase

      Show
      There are just minor changes to the produced HTML (mostly in CSS), so basically the test is to ensure that everything is displayed as it was before. Create a course in topics or weeks format with enabled groups and activity completion Add groups and grouppings to the course Create several sections and several activities, make sure you have among activities: Activity available only in one of the groups Activity conditionally available (i.e. time based or completion based, etc.) Activity conditionally available that should be displayed to students grayed-out Activity with manual completion Activity with automatic completion Label and/or other activity without URLs Glossary or other activity not supporting group mode Activity with subtypes (i.e. mod_assignment) View the course as a teacher (both in view and edit mode) and as a student, make sure it looks the same as in master branch Make sure teacher can move modules in both JS enabled and disabled modes Make sure teacher can drag and drop file into course (in edit mode) Make sure student can change/view completion status Create course in social format Add some activities, make sure they are displayed correctly in social activities block In front page settings check the "Include a topic section" checkbox (numsections) Add site main menu block on the front page Add activities to the site main menu block and to the front page Make sure they are displayed correctly to both teacher (view/edit mode) and student Please re-test MDL-36808 , MDL-35884 , MDL-37015 , MDL-30899 , MDL-36736 because their changes were manually picked into renderer during rebase
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
      wip-MDL-37085-master

      Description

      Move HTML rendering from functions print_section() and print_section_add_menus() to renderer

      This includes:

      • deprecate get_print_section_cm_text(), substitute with cm_info::get_formatted_content() and cm_info::get_formatted_name()
      • deprecate make_editing_buttons(), substitute with course_get_cm_edit_actions() and core_course_renderer::course_renderer_cm_edit_actions()
      • deprecate print_section_add_menus(), substitute with core_course_renderer::course_section_add_cm_control()
      • deprecate print_section(), substitute with several functions in renderer, the main is core_course_renderer::course_section_cm_list(), which calls
        • core_course_renderer::course_section_cm(), which calls
          • core_course_renderer::course_section_cm_name()
          • core_course_renderer::course_section_cm_text()
          • core_course_renderer::course_section_cm_availability()
          • core_course_renderer::course_section_cm_completion()
          • core_course_renderer::course_section_cm_edit_actions()

      Also changes include:

      • modchooser is only loaded in core_course_renderer, so themes can overwrite not to use it and not to include javascript for it if it is not used
      • get_module_metadata() now returns instance of moodle_url in ->link attribute (instead of string),
      • added fields cm_info::$coursegroupmodeforce and cm_info::$coursegroupmode, removed hacks to overwrite cm_info::$groupmode in case of course forcing before passing them to course_get_cm_edit_actions() (former make_editing_buttons() )

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  9 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    14/May/13