Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37088

bad operator in ldap "sync_user" method

    XMLWordPrintable

Details

    Description

      Hello,

      There is a little mistake here :
      http://git.moodle.org/gw?p=moodle.git;a=blob;f=auth/ldap/auth.php;h=fed0bae7aadf466717deba63f921425e3f63097b;hb=HEAD#l714

      Operator should be != or variables must be casted (because one is int and other is string).

      Currently this condition always return true. Fortunately there is no bad effect, just a resource/time waste.

      Thanks.

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-36118 LDAP sync_users performs redundant actions

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              iarenaza Iñaki Arenaza
              jboulen Julien Boulen
              Sam Hemelryk Sam Hemelryk
              Jason Fowler Jason Fowler
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                14/Jan/13