[MDL-37088] bad operator in ldap "sync_user" method - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.4
Fix Version/s: 2.2.7, 2.3.4, 2.4.1
Component/s: Authentication
Labels:
- triaged

Affected Branches:
MOODLE_24_STABLE
Fixed Branches:
MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
Pull from Repository:
https://github.com/iarenaza/moodle.git
Pull Master Branch:
wip_master_mdl-37088_bad_operator_ldap_sync_user
Pull Master Diff URL:
https://github.com/iarenaza/moodle/compare/master...wip_master_mdl-37088_bad_operator_ldap_sync_user

Description

Hello,

There is a little mistake here :
http://git.moodle.org/gw?p=moodle.git;a=blob;f=auth/ldap/auth.php;h=fed0bae7aadf466717deba63f921425e3f63097b;hb=HEAD#l714

Operator should be != or variables must be casted (because one is int and other is string).

Currently this condition always return true. Fortunately there is no bad effect, just a resource/time waste.

Thanks.

Attachments

Issue Links

is duplicated by

MDL-36118 LDAP sync_users performs redundant actions

Closed

Activity

People

Assignee:: Iñaki Arenaza

Reporter:: Julien Boulen

Integrator:: Sam Hemelryk

Tester:: Jason Fowler

Participants:: Dan Poltawski, Eloy Lafuente (stronk7), Iñaki Arenaza, Jason Fowler, Julien Boulen, Michael de Raadt, Sam Hemelryk

Component watchers:: Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 11/Dec/12 1:52 AM

Updated:: 21/Aug/14 6:58 PM

Resolved:: 15/Dec/12 8:29 AM

Fix Release Date:: 14/Jan/13