Details
-
Improvement
-
Status: Closed
-
Major
-
Resolution: Fixed
-
2.4
-
MOODLE_24_STABLE
-
MOODLE_25_STABLE
-
MDL-37122-master -
Description
The assignment, forum and workshop activities add the course limit to the list of allowed file sizes, even when this filesize is greater than the site limit.
Replication steps:
- Log in as admin
- Set the site file limit to something high (or server limit) at Settings > Site admin > Security > Site policies > Maximum uploaded file size (maxbytes)
- Go to a course (or create one)
- Edit the settings for the course and set the course file limit to the site limit
- Go back to the site limit and reduce it to something lower, eg 2MB.
- Go back to the course and edit the settings
- Note the list of options for the file limit (it goes up to the site limit now), but this is not the value stored in the DB
- Do not save the course settings (if you do, you need to start again)
- Go back to the course page and add or edit an assignment activity
- Note the list of options for the file limit
- Add a forum and workshop activity and note the list of file size options there also
Expected result: The activity file limits should only go up to the site limit
Actual result: The course limit saved in the DB is included in the lists
This is happening in the settings pages for these activities, not in the library function which returns the list of allowed file sizes. The settings pages should check that the course limit is valid before adding it to the list of filesizes.
It should be noted that even when the activities limit is greater than the site limit, the site limit is still applied when students upload files.
I checked the Database activity and other modules and they do not appear to add the course limit to the list of file sizes.
Attachments
Issue Links
- caused a regression
-
MDL-39077 get_max_upload_sizes does not include option for 0 when $CFG->maxbytes is not set.
-
- Closed
-
-
MDL-38748 File upload submission file size
-
- Closed
-
-
MDL-46887 Assignment file "Maximum submission size " set to "Activity upload limit" not enforced
-
- Closed
-
- has a non-specific relationship to
-
MDL-32861 Course file upload limit is ignored when maxbytes is set to server limit
-
- Closed
-
- is duplicated by
-
MDL-38725 File upload submission plugin settings break general principles in Moodle for file size handling
-
- Closed
-
- Testing discovered
-
MDL-36644 Course upload limit option appears last in the list of available upload limit options when editing an assignment
-
- Closed
-