Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-35672 META JavaScript performance issues
  3. MDL-37162

Use CSS to make mod show/hide icons not look "clickable" in hidden sections

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.6, 2.3.3, 2.4
    • Fix Version/s: 2.3.5, 2.4.2
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide
      • Add an activity or resource to a section
      • Hide the section
      • Move your mouse over the hide/show icon for the resource, and confirm that it remains as the arrow rather than going to the hand icon
      • Move your mouse over the hide/show icon in a non-hidden section, and confirm that it does change to the hand icon
      Show
      Add an activity or resource to a section Hide the section Move your mouse over the hide/show icon for the resource, and confirm that it remains as the arrow rather than going to the hand icon Move your mouse over the hide/show icon in a non-hidden section, and confirm that it does change to the hand icon
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-37162_master

      Description

      Currently, the resource toolbox initialiser (specifically, _setup_for_resource) wastes time by mucking about fetching show/hide icons and then fetching their section ancestor in order to check whether it's hidden, then pointlessly setting the show/hide icon's cursor value to "auto" if the section is hidden. This achieves nothing except wasting time - it's not even doing what it was intended to, since cursor:auto on an a tag (which the show/hide icon is) results in the hand icon anyway!

      This should be done using CSS instead (setting it to cursor:default, which actually achieves the stated goal ("Disable" show/hide icons (change cursor to not look clickable) if section is hidden).

        Attachments

          Activity

            People

            Assignee:
            paul.n Paul Nicholls
            Reporter:
            paul.n Paul Nicholls
            Peer reviewer:
            Andrew Nicols
            Integrator:
            Dan Poltawski
            Tester:
            David Monllaó
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            1 Vote for this issue
            Watchers:
            8 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/Mar/13