Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37168

LTI quick title edit doesn't update name in gradebook

    XMLWordPrintable

Details

    • MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_32_STABLE
    • MOODLE_31_STABLE, MOODLE_32_STABLE
    • MDL-37168-master
    • Hide
      1. Use ngrok or anything you might need to make your site publically available
      2. Create an LTI instance
        1. Use http://lti.tools/test/tp.php as the launch url, "secret" as the secret, and anything as the key
        2. Turn accepts grades is off (privacy group)
      3. Rename the instance
      4. Check the gradebook
      5. Make sure the new name is shown
      6. Open the instance
      7. Go to Outcomes 1
      8. Press update
      9. Insert a grade between 0 and 1
      10. Make sure it does not show up in moodle.
      11. Edit the settings for the LTI instance
      12. Turn accepts grades on
      13. Rename the instance
      14. Check the gradebook
      15. Make sure the new name is shown
      16. Open the instance
      17. Go to Outcomes 1
      18. Press update
      19. Insert a grade between 0 and 1
      20. Make sure it shows up in moodle.
      Show
      Use ngrok or anything you might need to make your site publically available Create an LTI instance Use http://lti.tools/test/tp.php as the launch url, "secret" as the secret, and anything as the key Turn accepts grades is off (privacy group) Rename the instance Check the gradebook Make sure the new name is shown Open the instance Go to Outcomes 1 Press update Insert a grade between 0 and 1 Make sure it does not show up in moodle. Edit the settings for the LTI instance Turn accepts grades on Rename the instance Check the gradebook Make sure the new name is shown Open the instance Go to Outcomes 1 Press update Insert a grade between 0 and 1 Make sure it shows up in moodle.
    • 3.3 sprint 5

    Description

      This is a followup of MDL-34791, where testing discovered that quick-editing one lti activity title does not lead to the title changed in the gradebook.

      From Andrew's research:

      This is a bug in the LTI module (or arguably lib/gradelib.php::grade_update_mod_grades()).

      grade_update_mod_grades() only calls the grade_item_update function if both:

      • MODNAME_grade_item_update; and
      • MODNAME_update_grades
        exist.

      If one of them doesn't exist, then neither is called.

      In the case of the LTI module only the _grade_item_update function exists; and _updatee_grades does not so neither get called.

      So this is about to decide if current behavior of grade_update_mod_grades is correct AND/OR if we need to "complete" the lti module to have the gradebook api implemented.

      Ciao

      Attachments

        Issue Links

          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-59107 Editing activity title using quick editing button doesn't get reflected in my overview

          • Major - Major loss of function, incorrect output
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. CONTRIB-4246 Attendance activity quick title edit doesn't update name in gradebook

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Testing discovered

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-34791 Activity quick title edit doesn't update name in gradebook

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-58352 Boost breadcrumb not present in frametop layout

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-58374 LTI gives no debug information when message verification fails

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              johno John Okely
              stronk7 Eloy Lafuente (stronk7)
              Ankit Agarwal Ankit Agarwal
              David Monllaó David Monllaó
              David Mudrák (@mudrd8mz) David Mudrák (@mudrd8mz)
              Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie, Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie
              Votes:
              3 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                8/May/17