[MDL-37171] E_STRICT and reference assignments with pear/excel stuff - Moodle Tracker

XML

Word

Printable

Testing Instructions:

Hide

For developers:

1/ look at the source code and test all affected places that generate XLS files

Show
For developers: 1/ look at the source code and test all affected places that generate XLS files
Affected Branches:
MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
Fixed Branches:
MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
Pull from Repository:
git://github.com/skodak/moodle.git
Pull Master Branch:
w50_~~MDL-37171~~_m25_outdatedexcel
Pull Master Diff URL:
https://github.com/skodak/moodle/compare/master...w50_MDL-37171_m25_outdatedexcel

This is a followup of ~~MDL-36640~~.

It seems that the pear lib we use to handle excel files (used widely) has some e_strict problems.

grep -r add_worksheet * | grep '=&'

This is about to:

Ciao

Discovered while testing

MDL-37253 Get rid of the lib/excel/test.php file

has a non-specific relationship to

MDL-37204 Look for a replacement for pear/excel library...

Testing discovered

MDL-36640 print_log_csv, xls, and ods try to run get_field with a non-numeric ID