Moodle
  1. Moodle
  2. MDL-37171

E_STRICT and reference assignments with pear/excel stuff

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Minor Minor
        • Resolution: Fixed
        • Affects Version/s: 2.2.6, 2.3.3, 2.4, 2.5
        • Fix Version/s: 2.2.7, 2.3.4, 2.4.1
        • Component/s: Libraries
        • Labels:
        • Rank:
          46744

          Description

          This is a followup of MDL-36640.

          It seems that the pear lib we use to handle excel files (used widely) has some e_strict problems.

          grep -r add_worksheet * | grep '=&'

          This is about to:

          • understand why/where it happens.
          • look and implement a possible solution.

          Ciao

            Issue Links

            discovered while testing

            Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-36640 print_log_csv, xls, and ods try to run get_field with a non-numeric ID

            • Minor - Minor loss of function where workaround is possible
            • Closed
            has a non-specific relationship to

            Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-37204 Look for a replacement for pear/excel library...

            • Minor - Minor loss of function where workaround is possible
            • Closed
            testing discovered

            Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-37253 Get rid of the lib/excel/test.php file

            • Minor - Minor loss of function where workaround is possible
            • Closed

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Petr Škoda added a comment - - edited

              The pear excel lib is a very old PHP4 code that is not maintained any more, we should probably switch to something XML based instead in the future...

              Show
              Petr Škoda added a comment - - edited The pear excel lib is a very old PHP4 code that is not maintained any more, we should probably switch to something XML based instead in the future...
              Hide
              Permalink
              Eloy Lafuente (stronk7) added a comment -

              I've created MDL-37204 about to look for alternatives.

              Show
              Eloy Lafuente (stronk7) added a comment - I've created MDL-37204 about to look for alternatives.
              Hide
              Permalink
              Eloy Lafuente (stronk7) added a comment -

              Integrated (22, 23, 24 & master), thanks!

              Show
              Eloy Lafuente (stronk7) added a comment - Integrated (22, 23, 24 & master), thanks!
              Hide
              Permalink
              Mark Nelson added a comment -

              Hi, looks good. However, for the survey module in integration master the references were not removed, so there was a strict standards warning in the excel I downloaded.

              Show
              Mark Nelson added a comment - Hi, looks good. However, for the survey module in integration master the references were not removed, so there was a strict standards warning in the excel I downloaded.
              Hide
              Permalink
              Mark Nelson added a comment -

              Also, for all branches the file 'lib/excel/test.php' was not changed either. I assume this was intentional as this file is not used anywhere afaik.

              Show
              Mark Nelson added a comment - Also, for all branches the file 'lib/excel/test.php' was not changed either. I assume this was intentional as this file is not used anywhere afaik.
              Hide
              Permalink
              Petr Škoda added a comment -

              oops, patch pushed to 24 and master branch, sorry

              Show
              Petr Škoda added a comment - oops, patch pushed to 24 and master branch, sorry
              Hide
              Permalink
              Eloy Lafuente (stronk7) added a comment - - edited

              new commits added to 24 and master. Also MDL-37253 created about the test.php file (better if we take rid of it).

              So I'm passing this on behalf of Mark... thanks guys!

              Edited: Mark, sorry, on behalf of Mark.

              Show
              Eloy Lafuente (stronk7) added a comment - - edited new commits added to 24 and master. Also MDL-37253 created about the test.php file (better if we take rid of it). So I'm passing this on behalf of Mark... thanks guys! Edited: Mark, sorry, on behalf of Mark.
              Hide
              Permalink
              Eloy Lafuente (stronk7) added a comment -

              Changes are now upstream, thanks for your collaboration!

              If you are going to have any celebration next days, enjoy with your gang, if not, too!

              Ciao

              Show
              Eloy Lafuente (stronk7) added a comment - Changes are now upstream, thanks for your collaboration! If you are going to have any celebration next days, enjoy with your gang, if not, too! Ciao

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: