[MDL-37181] Backups report show all courses with status Skipped. - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Critical
Resolution: Fixed
Affects Version/s: 2.4, 2.4.1, 2.4.2, 2.5, 2.6
Fix Version/s: 2.4.7, 2.5.3
Component/s: Backup, Reports
Labels:
- partner
- patch
- triaged

Affected Branches:
MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
Fixed Branches:
MOODLE_24_STABLE, MOODLE_25_STABLE
Pull from Repository:
https://github.com/markn86/moodle.git
Pull Master Branch:
~~MDL-37181~~_master
Pull Master Diff URL:
https://github.com/markn86/moodle/compare/master...MDL-37181_master
Testing Instructions:
Hide

Log in as an administrator and create a new course.

Visit <yoursite>/admin/settings.php?section=automated

Set 'Active' to 'Enabled', select the current day for 'Schedule' and set the time to 5 minutes in the future. Note, the time selected here is in GMT, so do not set this assuming it is in the user timezone.

Open another tab and visit <yoursite>/admin/cron.php.

Open another tab and visit <yoursite>/report/backups/index.php and check when the 'Next backup' is scheduled. It should be 5 minutes in the future.

Wait until you pass the time listed.

Run the cron and then refresh the backup report page and ensure the status has been set to 'OK' for the new course.

Run the cron again, refresh the backup report page and check that the status still says 'OK' for the new course.
Show
Log in as an administrator and create a new course. Visit <yoursite>/admin/settings.php?section=automated Set 'Active' to 'Enabled', select the current day for 'Schedule' and set the time to 5 minutes in the future. Note, the time selected here is in GMT, so do not set this assuming it is in the user timezone. Open another tab and visit <yoursite>/admin/cron.php. Open another tab and visit <yoursite>/report/backups/index.php and check when the 'Next backup' is scheduled. It should be 5 minutes in the future. Wait until you pass the time listed. Run the cron and then refresh the backup report page and ensure the status has been set to 'OK' for the new course. Run the cron again, refresh the backup report page and check that the status still says 'OK' for the new course.

Story Points:
13
Sprint:
BACKEND Sprint 6

Description

The backups report is showing the status since the last cron, but should show the status from the last (un)succesfull backup. The information in the time taken column can give a clue if an automatic backup happened or was skipped, but now one can only know if the last backup was succesfull - skipped - unfinished - with a warning - with error, by checking the backup destination folder and mdl_backup_controllers table.

Attachments

Issue Links

blocks

MDL-42201 Creating a course and running the cron causes 'Error' to be displayed in backup report.

Closed

Discovered while testing

MDL-36582 Notices in chat when running cron on stable master.

Closed

duplicates

MDL-39861 Backup report inconsistencies

Closed

has been marked as being related by

MDL-32148 Automated backups : Skip backup of courses that have remained unmodified since last backup

Closed

Activity

People

Assignee:: Mark Nelson

Reporter:: Renaat Debleu

Peer reviewer:: Frédéric Massart

Integrator:: Eloy Lafuente (stronk7)

Tester:: Jérôme Mouneyrac

Participants:: Bob Rametta, Chris Chapman, Chris Follin, Dan Poltawski, David O'Brien, Dixie Harrison, Eloy Lafuente (stronk7), Frédéric Massart, Helen Foster, Jérôme Mouneyrac, Mark Nelson, Mark Pearson, Michael de Raadt, Paul Vaughan, Renaat Debleu, Tulio Nogueira

Component watchers:: Adrian Greeve, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 7 Vote for this issue

Watchers:: 14 Start watching this issue

Dates

Created:: 16/Dec/12 2:28 AM

Updated:: 28/Jul/18 1:15 AM

Resolved:: 18/Oct/13 5:56 PM

Fix Release Date:: 11/Nov/13