Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36504 enrol improvements 2.5 META
  3. MDL-37187

cleanup enrol_flatfile

    XMLWordPrintable

Details

    • Sub-task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.4
    • 2.5
    • Enrolments
    • MOODLE_24_STABLE
    • MOODLE_25_STABLE
    • w02_MDL-37187_m25_flatfile
    • Hide

      1/ execute phpunit tests
      2/ create some flatfile enrolment file and execute it or wait for cron
      3/ try to manually edit enrolments as administrator (or any other role if you override plugin permissions)

      Show
      1/ execute phpunit tests 2/ create some flatfile enrolment file and execute it or wait for cron 3/ try to manually edit enrolments as administrator (or any other role if you override plugin permissions)

    Description

      Current flatfile plugin contains multiple problems and lack of functionality:

      • problematic coding style
      • lacks manual management of enrolments
      • missing unenrolment action
      • impossible to sync via CLI
      • cron progress trace handling is non-standard
      • restore support is missing
      • unit tests are missing
      • no support for different encodings
      • problems with unicode support
      • no support for CSV text quoting or different separators
      • start time can not be specified without end time
      • etc.

      This patch implements all this missing functionality and fixes all know bugs and bugs discovered during testing. The unit tests should cover all the functionality except manual editing of enrolments.

      Attachments

        Issue Links

          caused a regression

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-51431 Enrol start date incorrect in enrol_flatfile

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has been marked as being related by

          Improvement - An enhancement to an existing Moodle feature. MDL-35511 We are not using component + itemid for self enrolments

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is blocked by

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-37184 refactor user_enrolments edit page

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Improvement - An enhancement to an existing Moodle feature. MDL-37302 improve role protection and role unassignments

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

          Improvement - An enhancement to an existing Moodle feature. MDL-37286 progress_trace improvements

          • Major - Major loss of function, incorrect output
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-39340 Flatfile: Unenrollment of users not successful, even though admin notification says it was

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-39548 flatfile enrolment generates wrong email notifications to managers, teachers and students

          • Minor - Minor loss of function where workaround is possible
          • Closed
          will help resolve

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-27533 Course Reset does not remove students enrolled via Flat File CVS

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-34811 Ensure enrol_flatfile and enrolments via upload users from csv results are consistent

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-35659 Flatfile Enrol: If someone has more than one role in a particular course, and you delete one of those roles with a flatfile, ALL the roles are deleted.

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Improvement - An enhancement to an existing Moodle feature. MDL-18937 Make flatfile enrolements tolerant of quote delimited csv files

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              skodak Petr Skoda
              skodak Petr Skoda
              Dan Poltawski Dan Poltawski
              Dan Poltawski Dan Poltawski
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                14/May/13