Details

      Description

      While deleting 3rd party module "ForumNG" and its sub tables...
      I got the following error "Fatal error: Maximum execution time of 30 seconds exceeded" while deleting the 5th table on the list (probably a big one)
      adding:

      @ini_set('max_execution_time', 120);

      before line (574) on: /lib/xmldb/xmldb_table.php

      if (!$result) { //Skip on error
        continue;
      }
      @ini_set('max_execution_time', 120); // might take long time
      $name = trim($xmlkey['@']['NAME']);
      $key = new xmldb_key($name);
      $key->arr2xmldb_key($xmlkey);
      $this->keys[] = $key;

      Worked a round the issue. And I was able to delete the main table and all the sub tables.
      btw, my php.ini is set to max_execution_time = 30

      We might consider adding that extra php execution time at a better location inside the code.

        Gliffy Diagrams

          Activity

          Hide
          skodak Petr Skoda added a comment - - edited

          Hello, thanks for the report. I am testing a different patch that modifies the plugin uninstall method instead, the reason is that we usually do not set execution timeout in low level API such as XMLDB layer.

          Show
          skodak Petr Skoda added a comment - - edited Hello, thanks for the report. I am testing a different patch that modifies the plugin uninstall method instead, the reason is that we usually do not set execution timeout in low level API such as XMLDB layer.
          Hide
          poltawski Dan Poltawski added a comment -

          Integrated, thanks.

          Show
          poltawski Dan Poltawski added a comment - Integrated, thanks.
          Hide
          ankit_frenz Ankit Agarwal added a comment -

          Tried uninstalling a few mods, all worked good
          passing
          Thanks

          Show
          ankit_frenz Ankit Agarwal added a comment - Tried uninstalling a few mods, all worked good passing Thanks
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          And your fantastic code has met core, hope they become good friends for a long period.

          Closing, thanks!

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - And your fantastic code has met core, hope they become good friends for a long period. Closing, thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Jan/13