Moodle
  1. Moodle
  2. MDL-37211

Untranslated strings in course restore

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.3, 2.4.5, 2.5.1
    • Fix Version/s: 2.4.6, 2.5.2
    • Component/s: Backup, Translation
    • Labels:
    • Testing Instructions:
      Hide
      1. Start course restore process
      2. Make sure "Module", "Title" and "Userinfo" show up correctly in English
      3. Switch to some other language
      4. Navigate to Home /Site administration /Language /Language customisation
      5. Choose your local language. Then "Open package for editing"
      6. Choose the "backup.php" component
      7. Translate the tokens (strings) "title", "module" and "userinfo"
      8. Save
      9. Go back to Step (1) and make sure the strings on the restore page are displayed in your language.
      Show
      Start course restore process Make sure "Module", "Title" and "Userinfo" show up correctly in English Switch to some other language Navigate to Home /Site administration /Language /Language customisation Choose your local language. Then "Open package for editing" Choose the "backup.php" component Translate the tokens (strings) "title", "module" and "userinfo" Save Go back to Step (1) and make sure the strings on the restore page are displayed in your language.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-37211_master

      Description

      When restoring a course, there is a page that shows you the contents of the course, with a table for each course section. The table headings "Module", "Title" & "Userinfo" don't appear to be translatable.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Helen Foster added a comment -

            David, thanks for your report.

            I'm attaching a screenshot showing the untranslated strings.

            Show
            Helen Foster added a comment - David, thanks for your report. I'm attaching a screenshot showing the untranslated strings.
            Hide
            Michael de Raadt added a comment -

            Hi, Nadav.

            (checklist taken from http://docs.moodle.org/dev/Peer_reviewing_checklist)

            [Y] Syntax
            [Y] Whitespace
            [Y] Output
            [N] Language
            [-] Databases
            [N] Testing
            [-] Security
            [-] Documentation
            [N] Git
            [Y] Sanity check
            

            The new strings should go in lang/en/backup.php and the get_string() calls should be adjusted accordingly.

            In your testing instructions, I was considering how to assure the new strings are appearing correctly in other languages. I realise that after this change is integrated it's unlikely they will be translated immediately, but perhaps the test instructions could lead the user through the process of updating the language strings through the Moodle interface before testing the restore interface in another language.

            As this issue is a bug, it would be good to have a fix for 2.4 and 2.5, although I suspect it would cherry-pick easily to those branches.

            Your commit message should include the component "Backup" after the issue ID. The message should describe the change rather than just reflecting the issue summary.

            Show
            Michael de Raadt added a comment - Hi, Nadav. (checklist taken from http://docs.moodle.org/dev/Peer_reviewing_checklist ) [Y] Syntax [Y] Whitespace [Y] Output [N] Language [-] Databases [N] Testing [-] Security [-] Documentation [N] Git [Y] Sanity check The new strings should go in lang/en/backup.php and the get_string() calls should be adjusted accordingly. In your testing instructions, I was considering how to assure the new strings are appearing correctly in other languages. I realise that after this change is integrated it's unlikely they will be translated immediately, but perhaps the test instructions could lead the user through the process of updating the language strings through the Moodle interface before testing the restore interface in another language. As this issue is a bug, it would be good to have a fix for 2.4 and 2.5, although I suspect it would cherry-pick easily to those branches. Your commit message should include the component "Backup" after the issue ID. The message should describe the change rather than just reflecting the issue summary.
            Hide
            Nadav Kavalerchik added a comment -

            Hi Michael,

            Thank you for adding the http://docs.moodle.org/dev/Peer_reviewing_checklist link. I did not read it for a long time.
            And it was refreshing

            I have moved the strings into lang/en/backup.php and changed the get_string() accordingly.
            I have updated the Instructions.
            I have updated the git commit message.
            I guess it can be easily cherry-picked into 2.4 and 2.5 so I was lazy enough to leave it be.
            I have rebased it onto latest master (16/8/2013)

            I think I am ready

            Show
            Nadav Kavalerchik added a comment - Hi Michael, Thank you for adding the http://docs.moodle.org/dev/Peer_reviewing_checklist link. I did not read it for a long time. And it was refreshing I have moved the strings into lang/en/backup.php and changed the get_string() accordingly. I have updated the Instructions. I have updated the git commit message. I guess it can be easily cherry-picked into 2.4 and 2.5 so I was lazy enough to leave it be. I have rebased it onto latest master (16/8/2013) I think I am ready
            Hide
            Michael de Raadt added a comment -

            Thanks for working in that, Nadav.

            Sending to integration.

            Show
            Michael de Raadt added a comment - Thanks for working in that, Nadav. Sending to integration.
            Hide
            Dan Poltawski added a comment -

            Thanks for the fix Nadav! I've integrated this to master, 25 and 24

            Show
            Dan Poltawski added a comment - Thanks for the fix Nadav! I've integrated this to master, 25 and 24
            Hide
            David Monllaó added a comment -

            It passes Everything working as described in 24, 25 and master

            Show
            David Monllaó added a comment - It passes Everything working as described in 24, 25 and master
            Hide
            Damyon Wiese added a comment -

            There was a young man named McGee
            Who thought squashing bugs was easy
            He tried it one day
            And to his dismay
            The bug guts made his keyboard all greasy

            Thanks!

            This has issue has been fixed and released in Moodle.

            Show
            Damyon Wiese added a comment - There was a young man named McGee Who thought squashing bugs was easy He tried it one day And to his dismay The bug guts made his keyboard all greasy Thanks! This has issue has been fixed and released in Moodle.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: