Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37220

Drag and drop 'add file' icon looks very blocky

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.4, 2.5
    • Fix Version/s: 2.4.1
    • Component/s: Course
    • Labels:
    • Testing Instructions:
      Hide

      Test with browsers that support drag and drop upload (Chrome, Firefox, IE10) and a range of themes:

      1. Visit a course page
      2. Turn on editing
      3. Drag a file onto the page (but do not drop it)
      4. Check the green '+' icon looks reasonable and the semi-transparent edges do not clash with the theme
      Show
      Test with browsers that support drag and drop upload (Chrome, Firefox, IE10) and a range of themes: Visit a course page Turn on editing Drag a file onto the page (but do not drop it) Check the green '+' icon looks reasonable and the semi-transparent edges do not clash with the theme
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      MDL-37220_dnd_icon

      Description

      A small amount of transparency added to the outer pixels greatly improves the smoothness of the 'add file' icon.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            davosmith Davo Smith added a comment -

            My artistic skills do not stretch as far as recreating the entire icon in SVG, however, this adjusting the transparency of a few of the pixels around the edge of this icon makes it look far more rounded than it was looking before.

            Show
            davosmith Davo Smith added a comment - My artistic skills do not stretch as far as recreating the entire icon in SVG, however, this adjusting the transparency of a few of the pixels around the edge of this icon makes it look far more rounded than it was looking before.
            Hide
            poltawski Dan Poltawski added a comment -

            Thanks Davo!

            Barbara is away for a few weeks so we won't be able to get a new icon from her, in the meantime this seems like a worthwile improvement. If you could create the branch for 2.4 and added some quick testing instructions.

            Show
            poltawski Dan Poltawski added a comment - Thanks Davo! Barbara is away for a few weeks so we won't be able to get a new icon from her, in the meantime this seems like a worthwile improvement. If you could create the branch for 2.4 and added some quick testing instructions.
            Hide
            davosmith Davo Smith added a comment -

            2.4 branch + testing instructions added

            Show
            davosmith Davo Smith added a comment - 2.4 branch + testing instructions added
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Surely I' blind coz they look pretty similar, but can imagine the transparency helping with non-white themes and friends, so integrated (24 and master), thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Surely I' blind coz they look pretty similar, but can imagine the transparency helping with non-white themes and friends, so integrated (24 and master), thanks!
            Hide
            davosmith Davo Smith added a comment -

            The semi-transparent pixels were actually a blue colour, which means it looked bad on a white background (but probably reasonable on a blue background) ...

            Anyway, hopefully someone will be able to come up with an SVG version at some point which will make it obsolete.

            Show
            davosmith Davo Smith added a comment - The semi-transparent pixels were actually a blue colour, which means it looked bad on a white background (but probably reasonable on a blue background) ... Anyway, hopefully someone will be able to come up with an SVG version at some point which will make it obsolete.
            Hide
            markn Mark Nelson added a comment -

            The pictures alone (eg. viewing the diff) side by side seem as if the change is unnecessary, however I went through the testing instructions on the stable branch as well as the integration branch to compare the icons and can say it does make a difference, definitely an improvement. Passing.

            Show
            markn Mark Nelson added a comment - The pictures alone (eg. viewing the diff) side by side seem as if the change is unnecessary, however I went through the testing instructions on the stable branch as well as the integration branch to compare the icons and can say it does make a difference, definitely an improvement. Passing.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            And your fantastic code has met core, hope they become good friends for a long period.

            Closing, thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - And your fantastic code has met core, hope they become good friends for a long period. Closing, thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Jan/13