Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37224

Import Tool - Find a course Search button functions as Continue button

          Details

          • Type: Bug
          • Status: Closed
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 2.3.3, 2.4.1, 2.5
          • Fix Version/s: 2.3.5, 2.4.2
          • Component/s: Backup
          • Labels:
          • Testing Instructions:
            Hide
            1. Log in as an admin.
            2. Browse to a course.
            3. Select import from the course settings.
            4. Select a course and then enter a search phrase and click search.
            5. Make sure the search is run and that you aren't taken to the next step.
            Show
            Log in as an admin. Browse to a course. Select import from the course settings. Select a course and then enter a search phrase and click search. Make sure the search is run and that you aren't taken to the next step.
          • Affected Branches:
            MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
          • Fixed Branches:
            MOODLE_23_STABLE, MOODLE_24_STABLE
          • Pull from Repository:
          • Pull Master Branch:
            wip-MDL-37224-m25
          • Pull Master Diff URL:

            Description

            When using the Import tool, the 'Find a course' portion contains a bug with the Search button. The Search button "acts" as the Continue button when any course radio button is selected in the course. This button should instead produce search results (a list of available courses for the provided search field value).

              Gliffy Diagrams

                Attachments

                  Issue Links

                  duplicates

                  Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-33195 Search button initiates import process

                  • Minor - Minor loss of function where workaround is possible
                  • Closed

                    Activity

                    Ascending order - Click to sort in descending order
                    Hide
                    Permalink
                    samhemelryk Sam Hemelryk added a comment -

                    Thanks for creating this issue Eric. I've just tested now and can confirm that I was able to reproduce this bug.

                    The following steps highlight the issue:

                    1. Log in as an admin.
                    2. Browse to a course.
                    3. Select import from the course settings.
                    4. Select a course and then enter a search phrase and click search.
                    5. Notice it takes you to the next step rather than run the search.
                    Show
                    samhemelryk Sam Hemelryk added a comment - Thanks for creating this issue Eric. I've just tested now and can confirm that I was able to reproduce this bug. The following steps highlight the issue: Log in as an admin. Browse to a course. Select import from the course settings. Select a course and then enter a search phrase and click search. Notice it takes you to the next step rather than run the search.
                    Hide
                    Permalink
                    samhemelryk Sam Hemelryk added a comment -

                    Easy fix, I'm putting this up for integration review now.

                    Show
                    samhemelryk Sam Hemelryk added a comment - Easy fix, I'm putting this up for integration review now.
                    Hide
                    Permalink
                    stronk7 Eloy Lafuente (stronk7) added a comment -

                    Integrated (23, 24 & master), thanks!

                    Show
                    stronk7 Eloy Lafuente (stronk7) added a comment - Integrated (23, 24 & master), thanks!
                    Hide
                    Permalink
                    rajeshtaneja Rajesh Taneja added a comment -

                    I am not sure if this is correct behaviour, failing it to get more feedback.

                    If I enter search string but press continue, it still do search and doesn't let me continue.

                    Steps to reproduce:

                    1. Go to import
                    2. select a course
                    3. Enter text in search field
                    4. Click continue
                    5. It do search and remove course selection.
                    6. Select a course & click search
                    7. It do search and remove course selection (which is fine)

                    Failing this as both search and continue buttons are treated in same way.

                    Show
                    rajeshtaneja Rajesh Taneja added a comment - I am not sure if this is correct behaviour, failing it to get more feedback. If I enter search string but press continue , it still do search and doesn't let me continue. Steps to reproduce: Go to import select a course Enter text in search field Click continue It do search and remove course selection. Select a course & click search It do search and remove course selection (which is fine) Failing this as both search and continue buttons are treated in same way.
                    Hide
                    Permalink
                    stronk7 Eloy Lafuente (stronk7) added a comment -

                    ping!

                    Show
                    stronk7 Eloy Lafuente (stronk7) added a comment - ping!
                    Hide
                    Permalink
                    samhemelryk Sam Hemelryk added a comment -

                    Aha thanks for spotting that Raj. Indeed the same problem works in both directions.

                    Eloy I've created a patch for each branch based upon integration for you to pull in.
                    It uses the button to determine a search being run rather than the search input field (a better approach in general).

                    Repo: git://github.com/samhemelryk/moodle.git
                    23: wip-MDL-37224-m23-integration
                    24: wip-MDL-37224-m24-integration
                    25: wip-MDL-37224-m25-integration

                    Cheers
                    Sam

                    Show
                    samhemelryk Sam Hemelryk added a comment - Aha thanks for spotting that Raj. Indeed the same problem works in both directions. Eloy I've created a patch for each branch based upon integration for you to pull in. It uses the button to determine a search being run rather than the search input field (a better approach in general). Repo: git://github.com/samhemelryk/moodle.git 23: wip- MDL-37224 -m23-integration 24: wip- MDL-37224 -m24-integration 25: wip- MDL-37224 -m25-integration Cheers Sam
                    Hide
                    Permalink
                    stronk7 Eloy Lafuente (stronk7) added a comment -

                    Yeah, it has way more sense to check for the name of the used submit button, integrated!

                    And reseting for another testing round, thanks!

                    Show
                    stronk7 Eloy Lafuente (stronk7) added a comment - Yeah, it has way more sense to check for the name of the used submit button, integrated! And reseting for another testing round, thanks!
                    Hide
                    Permalink
                    rajeshtaneja Rajesh Taneja added a comment -

                    Thanks Sam and Eloy,

                    Works well now

                    Show
                    rajeshtaneja Rajesh Taneja added a comment - Thanks Sam and Eloy, Works well now
                    Hide
                    Permalink
                    damyon Damyon Wiese added a comment -

                    Thanks for your hard work - this issue has made it! Moodle is now a little bit better.

                    Regards, Damyon

                    Show
                    damyon Damyon Wiese added a comment - Thanks for your hard work - this issue has made it! Moodle is now a little bit better. Regards, Damyon

                      People

                      • Votes:
                        0 Vote for this issue
                        Watchers:
                        3 Start watching this issue

                        Dates

                        • Created:
                          Updated:
                          Resolved:
                          Fix Release Date:
                          11/Mar/13