Moodle

Import Tool - Find a course Search button functions as Continue button

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.3.3, 2.4.1, 2.5
  • Fix Version/s: 2.3.5, 2.4.2
  • Component/s: Backup
  • Labels:

Description

When using the Import tool, the 'Find a course' portion contains a bug with the Search button. The Search button "acts" as the Continue button when any course radio button is selected in the course. This button should instead produce search results (a list of available courses for the provided search field value).

Issue Links

duplicates

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-33195 Search button initiates import process

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Sam Hemelryk added a comment -

Thanks for creating this issue Eric. I've just tested now and can confirm that I was able to reproduce this bug.

The following steps highlight the issue:

  1. Log in as an admin.
  2. Browse to a course.
  3. Select import from the course settings.
  4. Select a course and then enter a search phrase and click search.
  5. Notice it takes you to the next step rather than run the search.
Show
Sam Hemelryk added a comment - Thanks for creating this issue Eric. I've just tested now and can confirm that I was able to reproduce this bug. The following steps highlight the issue: Log in as an admin. Browse to a course. Select import from the course settings. Select a course and then enter a search phrase and click search. Notice it takes you to the next step rather than run the search.
Hide
Permalink
Sam Hemelryk added a comment -

Easy fix, I'm putting this up for integration review now.

Show
Sam Hemelryk added a comment - Easy fix, I'm putting this up for integration review now.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Integrated (23, 24 & master), thanks!

Show
Eloy Lafuente (stronk7) added a comment - Integrated (23, 24 & master), thanks!
Hide
Permalink
Rajesh Taneja added a comment -

I am not sure if this is correct behaviour, failing it to get more feedback.

If I enter search string but press continue, it still do search and doesn't let me continue.

Steps to reproduce:

  1. Go to import
  2. select a course
  3. Enter text in search field
  4. Click continue
  5. It do search and remove course selection.
  6. Select a course & click search
  7. It do search and remove course selection (which is fine)

Failing this as both search and continue buttons are treated in same way.

Show
Rajesh Taneja added a comment - I am not sure if this is correct behaviour, failing it to get more feedback. If I enter search string but press continue , it still do search and doesn't let me continue. Steps to reproduce: Go to import select a course Enter text in search field Click continue It do search and remove course selection. Select a course & click search It do search and remove course selection (which is fine) Failing this as both search and continue buttons are treated in same way.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

ping!

Show
Eloy Lafuente (stronk7) added a comment - ping!
Hide
Permalink
Sam Hemelryk added a comment -

Aha thanks for spotting that Raj. Indeed the same problem works in both directions.

Eloy I've created a patch for each branch based upon integration for you to pull in.
It uses the button to determine a search being run rather than the search input field (a better approach in general).

Repo: git://github.com/samhemelryk/moodle.git
23: wip-MDL-37224-m23-integration
24: wip-MDL-37224-m24-integration
25: wip-MDL-37224-m25-integration

Cheers
Sam

Show
Sam Hemelryk added a comment - Aha thanks for spotting that Raj. Indeed the same problem works in both directions. Eloy I've created a patch for each branch based upon integration for you to pull in. It uses the button to determine a search being run rather than the search input field (a better approach in general). Repo: git://github.com/samhemelryk/moodle.git 23: wip- MDL-37224 -m23-integration 24: wip- MDL-37224 -m24-integration 25: wip- MDL-37224 -m25-integration Cheers Sam
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Yeah, it has way more sense to check for the name of the used submit button, integrated!

And reseting for another testing round, thanks!

Show
Eloy Lafuente (stronk7) added a comment - Yeah, it has way more sense to check for the name of the used submit button, integrated! And reseting for another testing round, thanks!
Hide
Permalink
Rajesh Taneja added a comment -

Thanks Sam and Eloy,

Works well now

Show
Rajesh Taneja added a comment - Thanks Sam and Eloy, Works well now
Hide
Permalink
Damyon Wiese added a comment -

Thanks for your hard work - this issue has made it! Moodle is now a little bit better.

Regards, Damyon

Show
Damyon Wiese added a comment - Thanks for your hard work - this issue has made it! Moodle is now a little bit better. Regards, Damyon

People

Vote (0)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved: