Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37233

Skype status icon breaks on https sites

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.3.4, 2.4.1
    • Component/s: General
    • Labels:
    • Testing Instructions:
      Hide

      1/ set up SSL on your test server
      2/ use http in config.php - verify the status icon is shown next to skype id on profile page
      3/ use https in config.php - verify the status icon is NOT shown next to skype id on profile page
      4/ use http in config.php and enable loginhttps - verify the status icon is NOT shown next to skype id on profile page

      Show
      1/ set up SSL on your test server 2/ use http in config.php - verify the status icon is shown next to skype id on profile page 3/ use https in config.php - verify the status icon is NOT shown next to skype id on profile page 4/ use http in config.php and enable loginhttps - verify the status icon is NOT shown next to skype id on profile page
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w51_MDL-37233_m25_skype

      Description

      See my profile, the image is loaded over http, so doesn't get full gold star status, this used to cause popup warnings in IE.
      https://moodle.org/user/profile.php?id=104159&course=5

      https://jira.skype.com/browse/SPA-567 suggests they don't care.

      My +1 to remove skype icon alltogether. We don't give other IM services this treatment..

        Gliffy Diagrams

          Attachments

            Activity

            Show
            poltawski Dan Poltawski added a comment - https://jira.skype.com/browse/SPA-335
            Hide
            skodak Petr Skoda added a comment -

            Thanks for the report, the patch removes the status icon if SSL used on the profile page.

            Show
            skodak Petr Skoda added a comment - Thanks for the report, the patch removes the status icon if SSL used on the profile page.
            Hide
            poltawski Dan Poltawski added a comment -

            Thank Petr, integrated to 23, 24 and master.

            Show
            poltawski Dan Poltawski added a comment - Thank Petr, integrated to 23, 24 and master.
            Hide
            poltawski Dan Poltawski added a comment -

            Tested on master and 23. Looks good. Thanks Petr.

            Show
            poltawski Dan Poltawski added a comment - Tested on master and 23. Looks good. Thanks Petr.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Did you know that your awesome changes are the last ones landing to CVS?

            After 11 years, 2 months and 8 days... it's ended, died, closed, kaputt. Big thanks to it, has served us really well.

            Closing this as fixed, many thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Did you know that your awesome changes are the last ones landing to CVS? After 11 years, 2 months and 8 days... it's ended, died, closed, kaputt. Big thanks to it, has served us really well. Closing this as fixed, many thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Jan/13