Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37263

Cache event invalidation throws an error if there are no invalidated keys.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4.1
    • Component/s: Caching
    • Labels:

      Description

      There is no where in core presently that uses event invalidation so it can't be easily reproduced.

      But it is easy to spot the theoretical problem, have a look at the attached patch.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            samhemelryk Sam Hemelryk added a comment -

            Putting straight up for integration as this is a VERY basic fix.

            Show
            samhemelryk Sam Hemelryk added a comment - Putting straight up for integration as this is a VERY basic fix.
            Hide
            poltawski Dan Poltawski added a comment -

            Thanks Sam, i've integrated this now

            Show
            poltawski Dan Poltawski added a comment - Thanks Sam, i've integrated this now
            Hide
            poltawski Dan Poltawski added a comment -

            phpunit is green!

            Show
            poltawski Dan Poltawski added a comment - phpunit is green!
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Did you know that your awesome changes are the last ones landing to CVS?

            After 11 years, 2 months and 8 days... it's ended, died, closed, kaputt. Big thanks to it, has served us really well.

            Closing this as fixed, many thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Did you know that your awesome changes are the last ones landing to CVS? After 11 years, 2 months and 8 days... it's ended, died, closed, kaputt. Big thanks to it, has served us really well. Closing this as fixed, many thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Jan/13