Moodle
  1. Moodle
  2. MDL-37275

When choosing to add a web service function without selecting any a notice is displayed.

    Details

    • Testing Instructions:
      Hide
      1. Visit <yoursite>/admin/settings.php?section=externalservices
      2. Click to add a web service.
      3. Choose any name and click 'Add service'.
      4. On the next page click 'Add functions'.
      5. Do not select any function and click 'Add functions'.
      6. Ensure you are taken back to the page and a message saying that a function must be chosen is displayed.
      Show
      Visit <yoursite>/admin/settings.php?section=externalservices Click to add a web service. Choose any name and click 'Add service'. On the next page click 'Add functions'. Do not select any function and click 'Add functions'. Ensure you are taken back to the page and a message saying that a function must be chosen is displayed.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull 2.4 Branch:
      MDL-37275_m24
    • Pull Master Branch:
      MDL-37275_master
    • Rank:
      46874

      Description

      1. Visit <yoursite>/admin/settings.php?section=externalservices
      2. Click to add a web service.
      3. Choose any name and click 'Add service'.
      4. On the next page click 'Add functions'.
      5. Do not select any functions and click 'Add functions'.
      6. The following notice will occur.

      Notice: Undefined property: stdClass::$fids in <dirroot>/admin/webservice/service_functions.php on line 70 Warning: Invalid argument supplied for foreach() in /var/www/mstorage/sm/moodle/admin/webservice/service_functions.php on line 70

        Activity

        Hide
        Jérôme Mouneyrac added a comment -

        Thanks Mark for these commits.

        Show
        Jérôme Mouneyrac added a comment - Thanks Mark for these commits.
        Hide
        Mark Nelson added a comment -

        Looks like I didn't push anything yet, just prematurely filled out the tracker, whoops.

        Show
        Mark Nelson added a comment - Looks like I didn't push anything yet, just prematurely filled out the tracker, whoops.
        Hide
        Jérôme Mouneyrac added a comment -

        Ahah you tricked me So I removed the label.

        Show
        Jérôme Mouneyrac added a comment - Ahah you tricked me So I removed the label.
        Hide
        Jérôme Mouneyrac added a comment -

        as it's pretty minor and a GUI thing I would do the validation on the client (add "..., null, 'client'") - but I'm being picky it's fine like that too.

        Show
        Jérôme Mouneyrac added a comment - as it's pretty minor and a GUI thing I would do the validation on the client (add "..., null, 'client'") - but I'm being picky it's fine like that too.
        Hide
        Dan Poltawski added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Dan Poltawski added a comment -

        Integrated to master, 24 and 23. Thanks Mark

        Show
        Dan Poltawski added a comment - Integrated to master, 24 and 23. Thanks Mark
        Hide
        David Monllaó added a comment -

        It passes, tested in 23, 24 and master

        Show
        David Monllaó added a comment - It passes, tested in 23, 24 and master
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Surely you will be happy to know that your code is now part of Moodle upstream. Thanks, thanks!

        Closing as fixed, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Surely you will be happy to know that your code is now part of Moodle upstream. Thanks, thanks! Closing as fixed, ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: