Moodle
  1. Moodle
  2. MDL-37290

Breadcrumbs not correctly representing course category structure

    Details

    • Testing Instructions:
      Hide
      1. Log in as an admin
      2. Browse to course/category management.
      3. Turn on editing
      4. Create three categories.
      5. Browse to the category you created second on the course/category management screen.
      6. Check that the navbar contains the correct category.
      Show
      Log in as an admin Browse to course/category management. Turn on editing Create three categories. Browse to the category you created second on the course/category management screen. Check that the navbar contains the correct category.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull 2.4 Branch:
      wip-MDL-37290-m24
    • Pull Master Branch:
      wip-MDL-37290-m25
    • Rank:
      46893

      Description

      When I view 'Add or Edit Courses' I see the following breadcrumbs: Home / ▶ Courses / ▶ Science / ▶ Add/edit courses

      The 'Science' category has the parent 'Top' and is the first category in the list of courses and categories.

      However ALL other courses show the same breadcrumb structure even if they are not in the science category.

      I created a 'discussion' here https://moodle.org/mod/forum/discuss.php?d=218136 which has screenshots showing the issue.

      I noticed this when courses in English failed to load when I clicked on the course link shown above. Got an error about missing table or similar (sorry did not get screenshot and error no longer appears). I moved the courses into the 'Science' category then back out to 'top' and now the courses do load fine but the bread crumbs still don't work.

      Yesterday after completing the upgrade to 2.4 I notice that I had foreign key errors e.g.

        Issue Links

          Activity

          Hide
          Sam Hemelryk added a comment -

          Thanks for creating the issue John.

          I could reproduce the incorrect navbar issue this morning and have produced a fix for it that I'm putting up for integration right now.

          As for the error you experienced and the ongoing foriegn key notices that sounds like a separate issue.
          Definitely it sounds like corrupted data, but I don't know enough about the setup to help you more sorry.
          Perhaps worth trying is running the XMLDB editors foriegn key check.
          You can get to it by following these steps:

          1. Log in as an admin
          2. Browse to http://localhost/admin/tool/xmldb/
          3. Near the top of the screen you should see "[Check Foreign Keys]"
          4. Run that and keep en eye out for any warnings/errors it produces.

          Hope that helps.
          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Thanks for creating the issue John. I could reproduce the incorrect navbar issue this morning and have produced a fix for it that I'm putting up for integration right now. As for the error you experienced and the ongoing foriegn key notices that sounds like a separate issue. Definitely it sounds like corrupted data, but I don't know enough about the setup to help you more sorry. Perhaps worth trying is running the XMLDB editors foriegn key check. You can get to it by following these steps: Log in as an admin Browse to http://localhost/admin/tool/xmldb/ Near the top of the screen you should see " [Check Foreign Keys] " Run that and keep en eye out for any warnings/errors it produces. Hope that helps. Cheers Sam
          Hide
          Dan Poltawski added a comment -

          Thanks Sam, i've integrated that now.

          Show
          Dan Poltawski added a comment - Thanks Sam, i've integrated that now.
          Hide
          Ankit Agarwal added a comment -

          Found an unrelated issue. Linked the mdl.
          Passing this thanks

          Show
          Ankit Agarwal added a comment - Found an unrelated issue. Linked the mdl. Passing this thanks
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Did you know that your awesome changes are the last ones landing to CVS?

          After 11 years, 2 months and 8 days... it's ended, died, closed, kaputt. Big thanks to it, has served us really well.

          Closing this as fixed, many thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Did you know that your awesome changes are the last ones landing to CVS? After 11 years, 2 months and 8 days... it's ended, died, closed, kaputt. Big thanks to it, has served us really well. Closing this as fixed, many thanks!
          Hide
          John Leonard added a comment -

          Thanks to everyone who helped to fix this.

          Show
          John Leonard added a comment - Thanks to everyone who helped to fix this.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: