Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37333

Clicking "Clear theme caches" in Default theme selector redirects page to "Select theme for tablet device"

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.4, 2.5.1, 2.6
    • Fix Version/s: 2.4.6, 2.5.2
    • Component/s: Administration
    • Labels:
    • Testing Instructions:
      Hide
      1. Go to Site administration -> Appearance -> Themes -> Theme selector.
      2. Click on 'Clear theme caches'.
      3. Confirm the page refreshes to the 'Select device' page first encountered in step 1.
      4. Click on 'Change theme' for the 'default' device.
      5. Click on 'Clear theme caches'.
      6. Confirm the page refreshes to the 'default' device page first encountered in step 4.
      7. Go to Site administration -> Appearance -> Themes -> Theme selector and repeat steps 4-6 for each device confirming that the redirection goes back to the correct page.
      Show
      Go to Site administration -> Appearance -> Themes -> Theme selector. Click on 'Clear theme caches'. Confirm the page refreshes to the 'Select device' page first encountered in step 1. Click on 'Change theme' for the 'default' device. Click on 'Clear theme caches'. Confirm the page refreshes to the 'default' device page first encountered in step 4. Go to Site administration -> Appearance -> Themes -> Theme selector and repeat steps 4-6 for each device confirming that the redirection goes back to the correct page.
    • Workaround:
      Hide

      Go instead to Appearance > Theme settings and switch off (disable = uncheck the box) for 'Detect Mobile devices'. Now go beck to Appearance > Theme selector and you will see the FULL list of themes you can choose from for the DEFAULT theme. Once you have selected your chosen theme, you can go back to Theme settings and enable the 'Detect mobile devices' once again.

      Show
      Go instead to Appearance > Theme settings and switch off (disable = uncheck the box) for 'Detect Mobile devices'. Now go beck to Appearance > Theme selector and you will see the FULL list of themes you can choose from for the DEFAULT theme. Once you have selected your chosen theme, you can go back to Theme settings and enable the 'Detect mobile devices' once again.
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-37333_master

      Description

      When you CLICK on "Clear theme caches" above the "Default" in Theme selector 'Select Device' page, the page you are on changes to "Select theme for tablet device". Surely this is wrong, as you should be still in the 'Select device' theme selector page.

        Attachments

        1. index.php
          10 kB
        2. MDL-37333_after.jpg
          MDL-37333_after.jpg
          35 kB
        3. MDL-37333_before.jpg
          MDL-37333_before.jpg
          32 kB

          Activity

            People

            Assignee:
            gb2048 Gareth J Barnard
            Reporter:
            lazydaisy Mary Evans
            Integrator:
            Dan Poltawski
            Tester:
            Andrew Davis
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              9/Sep/13