Loading...

XML

Word

Printable

Affected Branches:
MOODLE_25_STABLE
Fixed Branches:
MOODLE_25_STABLE
Pull from Repository:
git://github.com/damyon/moodle.git
Pull Main Branch:
~~MDL-37337~~-master
Pull Main Diff URL:
https://github.com/damyon/moodle/compare/9e7e1b1c9e8dab3a8ec8a37dc5cc4e4d08bfe04b...MDL-37337-master
Testing Instructions:
Hide

Go to the create module screen for the assignment module

On the settings screen verify that you can only change the maximum number of files when the "File submissions" checkbox is checked

Create the assignment with "File submissions" enabled

Login as a student and verify you can upload files to the assignment

Login as a teacher

Edit the settings for the assignment

Turn "File submissions" off (unchecked)

Login as a student and verify you cannot upload files to the assignment
Show
Go to the create module screen for the assignment module On the settings screen verify that you can only change the maximum number of files when the "File submissions" checkbox is checked Create the assignment with "File submissions" enabled Login as a student and verify you can upload files to the assignment Login as a teacher Edit the settings for the assignment Turn "File submissions" off (unchecked) Login as a student and verify you cannot upload files to the assignment

This is partly because it is broken down into plugins which each add their own settings to the form, but it could still be improved.

Suggestions for improvement:

Add admin defaults for every setting on the page and allow settings to be locked by admin.
Combine all the submission enabled settings to a list of checkboxes on the same row instead of one row for each.
Allow templates at an admin level which can be used to auto fill out all the settings on the page. E.g. "File upload assignment"

More...

caused a regression

MDL-39415 "Column 'alwaysshowdescription' cannot be null" message when updating mod_assign settings

has a non-specific relationship to

MDL-37459 Allow "locked" and "advanced" checkboxes to be added to any admin setting.

will be (partly) resolved by

MDL-30637 Simplify moodle forms

will help resolve

MDL-37969 mod_assign: shortforms compatibility issue