Moodle
  1. Moodle
  2. MDL-37352

Grader report ajax error dialog doesnt display correctly

    Details

    • Testing Instructions:
      Hide

      You'll need a course with at least one activity and at least one student.

      Make sure the site setting "unlimitedgrades" is off.
      Make sure the site setting "grade_report_enableajax" is on.
      Purge caches using the purge cache link at the bottom of the page.

      Go to the grader report and click on a student grade.
      A text box will appear. Enter a grade that is above the activities maximum grade. Press enter on the keyboard.
      An error dialog with a non-transparent background should appear.
      Enter a valid grade. The grade should be accepted.

      Show
      You'll need a course with at least one activity and at least one student. Make sure the site setting "unlimitedgrades" is off. Make sure the site setting "grade_report_enableajax" is on. Purge caches using the purge cache link at the bottom of the page. Go to the grader report and click on a student grade. A text box will appear. Enter a grade that is above the activities maximum grade. Press enter on the keyboard. An error dialog with a non-transparent background should appear. Enter a valid grade. The grade should be accepted.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull Master Branch:
      MDL-37352_grader_ajax_error
    • Rank:
      46971

      Description

      When you get an ajax error on the grader report it doesnt display quite right. For example when entering a grade that is above the maximum allowed grade. See attached screenshot.

        Issue Links

          Activity

          Hide
          Andrew Davis added a comment -

          Adding testing instructions. I have a fix for this but due to connectivity issues I may not be able to post it until the 17th.

          Show
          Andrew Davis added a comment - Adding testing instructions. I have a fix for this but due to connectivity issues I may not be able to post it until the 17th.
          Hide
          Andrew Davis added a comment -

          Adding a branch and putting this up for peer review.

          Show
          Andrew Davis added a comment - Adding a branch and putting this up for peer review.
          Hide
          Jason Fowler added a comment -

          [Y] Syntax
          [-] Output
          [Y] Whitespace
          [-] Language
          [-] Databases
          [Y] Testing
          [-] Security
          [-] Documentation
          [Y] Git
          [Y] Sanity check

          Code looks good Andrew

          Show
          Jason Fowler added a comment - [Y] Syntax [-] Output [Y] Whitespace [-] Language [-] Databases [Y] Testing [-] Security [-] Documentation [Y] Git [Y] Sanity check Code looks good Andrew
          Hide
          Dan Poltawski added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Dan Poltawski added a comment -

          Hi Andrew,

          Should this be backported?

          Show
          Dan Poltawski added a comment - Hi Andrew, Should this be backported?
          Hide
          Andrew Davis added a comment -

          Yes it should actually. Preparing branches now.

          Show
          Andrew Davis added a comment - Yes it should actually. Preparing branches now.
          Hide
          Andrew Davis added a comment -

          Actually I'm temporarily unable to reach github for some mysterious reason. Is there any chance you could cherry-pick this for me?

          Show
          Andrew Davis added a comment - Actually I'm temporarily unable to reach github for some mysterious reason. Is there any chance you could cherry-pick this for me?
          Hide
          Dan Poltawski added a comment -

          yep, np

          Show
          Dan Poltawski added a comment - yep, np
          Hide
          Dan Poltawski added a comment -

          I had to fix a conflict in 2.3, but i've integrated this to master, 24 and 23.

          If you could check my 2.3 conflict resolution it would be good. Thanks!

          Show
          Dan Poltawski added a comment - I had to fix a conflict in 2.3, but i've integrated this to master, 24 and 23. If you could check my 2.3 conflict resolution it would be good. Thanks!
          Hide
          Andrew Davis added a comment -

          I think 2.3 looks fine.

          Show
          Andrew Davis added a comment - I think 2.3 looks fine.
          Hide
          David Monllaó added a comment -

          It passes, tested in 23 and master. I've noticed that when I update the grade with a correct value the 'course total' and 'overall average' values don't reflect the change

          Show
          David Monllaó added a comment - It passes, tested in 23 and master. I've noticed that when I update the grade with a correct value the 'course total' and 'overall average' values don't reflect the change
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Surely you will be happy to know that your code is now part of Moodle upstream. Thanks, thanks!

          Closing as fixed, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Surely you will be happy to know that your code is now part of Moodle upstream. Thanks, thanks! Closing as fixed, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: