[MDL-37355] WS servers cleaning process should auto cast object into array - Moodle Tracker

XML

Word

Printable

Testing Instructions:

Hide

phpunit externallib_testcase lib/tests/externallib_test.php

Also manually:
1- Edit any external functions to return an object. I personally used user/externallib.php:create_users(). i edited it to return user objects with id/username instead of arrays with id/username.
2- run the PHP-SOAP client (https://github.com/moodlehq/sample-ws-clients/tree/master/PHP-SOAP). You can test with REST too but you'll need to cheery-pick ~~MDL-37358~~.

You should see the resulting XML code with the new user id/username.

Show
phpunit externallib_testcase lib/tests/externallib_test.php Also manually: 1- Edit any external functions to return an object. I personally used user/externallib.php:create_users(). i edited it to return user objects with id/username instead of arrays with id/username. 2- run the PHP-SOAP client ( https://github.com/moodlehq/sample-ws-clients/tree/master/PHP-SOAP ). You can test with REST too but you'll need to cheery-pick MDL-37358 . You should see the resulting XML code with the new user id/username.
Affected Branches:
MOODLE_25_STABLE
Fixed Branches:
MOODLE_25_STABLE
Pull from Repository:
git://github.com/mouneyrac/moodle.git
Pull Master Branch:
~~MDL-37355~~-master
Pull Master Diff URL:
https://github.com/mouneyrac/moodle/compare/moodle:master...MDL-37355-master

WS servers cleaning process should auto cast object into array.

is blocked by

MDL-37358 REST server doesn't validate result when returning XML format

Participants:: Ankit Agarwal, Dan Poltawski, Eloy Lafuente (stronk7), Jérôme Mouneyrac, Michael de Raadt

Component watchers:: Juan Leyva, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)