Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37361

Allow teachers to mark activities as completed

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Initial setup

      1. Create a course and enable completion tracking.
      2. Enrol a student and a teacher in the course.
      3. Add an assignment A1 with manual completion tracking.
      4. Add an assignment A2 with automatic completion tracking where the criteria is:
        • Students must submit to the assignment to complete it.

      Confirming that overrides work, and that an override to 'incomplete' can still be completed by the student:

      1. Login as the student and go to the course
      2. Click on the check box next to A1 to complete it.
      3. Submit something to A2.
      4. Now, back on the main course page verify that both activities are shown as complete (ticked boxes).
      5. Now, login as "teacher1"
      6. From the course administration block, navigate to Reports -> Activity completion
      7. Verify that both activities are marked as completed.
      8. Click on the status icon for A1 and confirm when prompted.
      9. Verify the status has changed to incomplete and the icon is solid red.
      10. Click on the status icon for A2 and confirm when prompted.
      11. Verify the status has changed to incomplete and the icon is dotted red.
      12. Verify that the tooltips/title for the two statuses appear correct. Should say the user's name and be overridden by the current user.
      13. Refresh the page and confirm the changes are still there (both red overrides to incomplete).
      14. Now, override the same two activities to complete and confirm this works.
      15. Override back to incomplete before proceeding.
      16. Now, login as the student again and go to the course.
      17. Verify you can see the overridden statuses for the assignments, both incomplete and that the relevant icon is show (dotted vs solid outline).
      18. Click the manual completion box for A1.
      19. Verify the activity is marked as complete on course home.
      20. Edit your submission and submit again to A2
      21. Verify the activity is marked as complete on course home.

       Confirming that for automatic completion, overrides to complete won't be set back to incomplete by automatic completion triggers

      1. As the teacher, create a new assignment A3, and set up completion such that:
        • Students must submit AND
        • Students must receive a grade.
      2. Now, from the activity completion course report, override the status of the student's completion for A3 to 'Complete'
      3. Now, login as the student and go to the course
      4. Verify the completion status is shown as complete and is red to indicate that it's been overridden.
      5. Submit something for the assignment
      6. Back on the course home page, Verify you still see the red overridden completed status icon.
      Show
      Initial setup Create a course and enable completion tracking. Enrol a student and a teacher in the course. Add an assignment A1 with manual completion tracking. Add an assignment A2 with automatic completion tracking where the criteria is: Students must submit to the assignment to complete it. Confirming that overrides work, and that an override to 'incomplete' can still be completed by the student: Login as the student and go to the course Click on the check box next to A1 to complete it. Submit something to A2. Now, back on the main course page verify that both activities are shown as complete (ticked boxes). Now, login as "teacher1" From the course administration block, navigate to Reports -> Activity completion Verify that both activities are marked as completed. Click on the status icon for A1 and confirm when prompted. Verify the status has changed to incomplete and the icon is solid red. Click on the status icon for A2 and confirm when prompted. Verify the status has changed to incomplete and the icon is dotted red. Verify that the tooltips/title for the two statuses appear correct. Should say the user's name and be overridden by the current user. Refresh the page and confirm the changes are still there (both red overrides to incomplete). Now, override the same two activities to complete and confirm this works. Override back to incomplete before proceeding. Now, login as the student again and go to the course. Verify you can see the overridden statuses for the assignments, both incomplete and that the relevant icon is show (dotted vs solid outline). Click the manual completion box for A1. Verify the activity is marked as complete on course home. Edit your submission and submit again to A2 Verify the activity is marked as complete on course home.   Confirming that for automatic completion, overrides to complete won't be set back to incomplete by automatic completion triggers As the teacher, create a new assignment A3, and set up completion such that: Students must submit AND Students must receive a grade. Now, from the activity completion course report, override the status of the student's completion for A3 to 'Complete' Now, login as the student and go to the course Verify the completion status is shown as complete and is red to indicate that it's been overridden. Submit something for the assignment Back on the course home page, Verify you still see the red overridden completed status icon.
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_31_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-37361-master-revised

      Description

      The predefined conditions that automatically mark an activity as completed are fine. However, there may be times when a teacher needs to come in and manually mark an activity as completed. There could be any number of reasons for this:

      • physical object is submitted to complete an assignment instead of a file upload or text input
      • teacher wants to check quality of forum posts rather than just the total number of them
      • for whatever reason, paper test was taken instead of the Moodle online one and so the test needs to be marked as completed
      • SCORM activity did not complete properly and therefore was not registered as completed
      • the activity to complete is a physical one: give classroom presentation, attend workshop/seminar, join field trip, etc.

      Allowing teachers to mark activities as completed needs to be an OR condition in addition to the existing predefined conditions. Examples:

      • The student must post 5 discussions or replies, OR the teacher marks the activity as completed
      • The student must submit to this activity OR the teacher marks the activity as completed
      • The student must receive a grade for this activity OR the teacher marks the activity as completed

      I believe this makes course completion more flexible and also allows for non-online activities to be added as part of course completion.

      This thread may contain additional information: [https://moodle.org/mod/forum/discuss.php?d=218954

      ]

      The following are the main features of this new functionality:

      1. A user with the permission/capability "moodle/course:overridecompletion" should be able to override the current activity completion status from the Activity completion report "report/progress/index.php".
      2. The overriding applies only if the completion state is either Complete or Incomplete. It does not override the completion state if it is Pass of Fail.
      3. The overriding applies to the completion states set by both manual and automatic completion tracking.
      4. The id of the user performing the override will be recorded on the database.
      5. A completion state which has been set by override will not be changed automatically back to a status of incomplete from complete.
        • For an activity with status overridden to 'incomplete', automatic completion will still occur via normal triggers.
        • For an activity with status overridden to 'complete', automatic completion is skipped, so we don't accidentally, automatically change the status back to incomplete.
      6. Manual completion overrides have no impact on the current behaviour. I.e. Students can still mark as complete and incomplete, and the icons will reflect this. If the student changes an override (incomplete to complete or vice versa), then the icon shown will be the normal (non-override) completion icon.
      7. When a complete state has been set by override, it will have a different icon than normal completion states. The icon box border colour will be in red instead of grey
      8. When completion states are reset, for example when changing the tracking criteria, those overriding states will be reset as well.

       

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                96 Vote for this issue
                Watchers:
                62 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Nov/17