Moodle
  1. Moodle
  2. MDL-37378

Notice Undefined property timecheckstate when restoring old backups

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.3.5, 2.4.2
    • Component/s: Quiz
    • Labels:
      None
    • Rank:
      47001

      Description

      Restoring a 2.0 backup in Moodle 2.4 produce:
      Notice: Undefined property: stdClass::timecheckstate in C:\wamp\www\moodle_test\mod\quiz\backup\moodle2\restorequizstepslib.php on line309
      Most likely a regression caused by MDL-35717.

        Issue Links

          Activity

          Hide
          Tim Hunt added a comment -

          I think this fixes it. Jean-Michel, are you able to verify that? Thanks.

          Show
          Tim Hunt added a comment - I think this fixes it. Jean-Michel, are you able to verify that? Thanks.
          Hide
          Ankit Agarwal added a comment -

          Hi Tim,
          The patch looks good.
          I was looking to see what happens in apply_date_offset() for a value of 0, just to make sure if empty or isset check will make more sense. But it doesn't really matter here.

          So please feel free to submit for integration.
          Thanks

          Show
          Ankit Agarwal added a comment - Hi Tim, The patch looks good. I was looking to see what happens in apply_date_offset() for a value of 0, just to make sure if empty or isset check will make more sense. But it doesn't really matter here. So please feel free to submit for integration. Thanks
          Hide
          Tim Hunt added a comment -

          Thanks Ankit. Submitting for integration.

          Show
          Tim Hunt added a comment - Thanks Ankit. Submitting for integration.
          Hide
          Jean-Michel Vedrine added a comment -

          Hello Tim,
          Sorry I didn't saw your message because I was receiving any notifications since JIRA upgrade but they are working again now. Your fix solve the problem for me. Thanks.

          Show
          Jean-Michel Vedrine added a comment - Hello Tim, Sorry I didn't saw your message because I was receiving any notifications since JIRA upgrade but they are working again now. Your fix solve the problem for me. Thanks.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Sam Hemelryk added a comment -

          Thanks guys, this has been integrated now.

          Show
          Sam Hemelryk added a comment - Thanks guys, this has been integrated now.
          Hide
          Adrian Greeve added a comment -

          Tested on 2.3, 2.4 and master integration branches.
          No errors, warnings or notices.
          Test passed.

          Show
          Adrian Greeve added a comment - Tested on 2.3, 2.4 and master integration branches. No errors, warnings or notices. Test passed.
          Hide
          Dan Poltawski added a comment -

          Hurray! We did it! Thanks to all the reporters, testers, user and watchers for a bumper week of Moodling!

          Show
          Dan Poltawski added a comment - Hurray! We did it! Thanks to all the reporters, testers, user and watchers for a bumper week of Moodling!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: