Moodle
  1. Moodle
  2. MDL-37381

core_external::get_component_strings return wrong format information

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4.2
    • Component/s: Web Services
    • Labels:
    • Rank:
      47004

      Description

      web server return validation fail

        Issue Links

          Activity

          Hide
          Ankit Agarwal added a comment -

          Hi Jerome,
          patch looks good.
          [y] Syntax
          [y] Output
          [y] Whitespace
          [-] Language
          [-] Databases
          [y] Testing
          [-] Security
          [-] Documentation
          [y] Git
          [y] Sanity check

          You missed a full stop, but feel free to ignore and submit for integration
          Thanks

          Show
          Ankit Agarwal added a comment - Hi Jerome, patch looks good. [y] Syntax [y] Output [y] Whitespace [-] Language [-] Databases [y] Testing [-] Security [-] Documentation [y] Git [y] Sanity check You missed a full stop, but feel free to ignore and submit for integration Thanks
          Hide
          Ankit Agarwal added a comment -

          forgot to click the finish button
          Thanks

          Show
          Ankit Agarwal added a comment - forgot to click the finish button Thanks
          Hide
          Jérôme Mouneyrac added a comment -

          Thanks Ankit, I added the full stop. Submitting to integration.

          Show
          Jérôme Mouneyrac added a comment - Thanks Ankit, I added the full stop. Submitting to integration.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Dan Poltawski added a comment -

          Hi Jerome, could you be a bit more verbose about the problem here?

          Show
          Dan Poltawski added a comment - Hi Jerome, could you be a bit more verbose about the problem here?
          Hide
          Jérôme Mouneyrac added a comment -

          Yes sorry.
          The string returned is declared as PARAM_TEXT. When webservice servers validate the string, if the string contain more than TEXT, they fails the validation. The string can contain anything it does not have to be PARAM_TEXT.

          Note: at the end our web service servers validation process is an insurance for the web service developer that the function does not return any unexpected values. External clients still should validate all their input.

          Show
          Jérôme Mouneyrac added a comment - Yes sorry. The string returned is declared as PARAM_TEXT. When webservice servers validate the string, if the string contain more than TEXT, they fails the validation. The string can contain anything it does not have to be PARAM_TEXT. Note: at the end our web service servers validation process is an insurance for the web service developer that the function does not return any unexpected values. External clients still should validate all their input.
          Hide
          Dan Poltawski added a comment -

          Integrated to 24 and master. Thanks

          Show
          Dan Poltawski added a comment - Integrated to 24 and master. Thanks
          Hide
          Adrian Greeve added a comment -

          If the test is just to run the unit tests, then this test passes.
          Tested on master and 2.4.

          Show
          Adrian Greeve added a comment - If the test is just to run the unit tests, then this test passes. Tested on master and 2.4.
          Hide
          Dan Poltawski added a comment -

          Hurray! We did it! Thanks to all the reporters, testers, user and watchers for a bumper week of Moodling!

          Show
          Dan Poltawski added a comment - Hurray! We did it! Thanks to all the reporters, testers, user and watchers for a bumper week of Moodling!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: