Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37381

core_external::get_component_strings return wrong format information

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4.2
    • Component/s: Web Services
    • Labels:

      Description

      web server return validation fail

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            ankit_frenz Ankit Agarwal added a comment -

            Hi Jerome,
            patch looks good.
            [y] Syntax
            [y] Output
            [y] Whitespace
            [-] Language
            [-] Databases
            [y] Testing
            [-] Security
            [-] Documentation
            [y] Git
            [y] Sanity check

            You missed a full stop, but feel free to ignore and submit for integration
            Thanks

            Show
            ankit_frenz Ankit Agarwal added a comment - Hi Jerome, patch looks good. [y] Syntax [y] Output [y] Whitespace [-] Language [-] Databases [y] Testing [-] Security [-] Documentation [y] Git [y] Sanity check You missed a full stop, but feel free to ignore and submit for integration Thanks
            Hide
            ankit_frenz Ankit Agarwal added a comment -

            forgot to click the finish button
            Thanks

            Show
            ankit_frenz Ankit Agarwal added a comment - forgot to click the finish button Thanks
            Hide
            jerome Jérôme Mouneyrac added a comment -

            Thanks Ankit, I added the full stop. Submitting to integration.

            Show
            jerome Jérôme Mouneyrac added a comment - Thanks Ankit, I added the full stop. Submitting to integration.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            poltawski Dan Poltawski added a comment -

            Hi Jerome, could you be a bit more verbose about the problem here?

            Show
            poltawski Dan Poltawski added a comment - Hi Jerome, could you be a bit more verbose about the problem here?
            Hide
            jerome Jérôme Mouneyrac added a comment -

            Yes sorry.
            The string returned is declared as PARAM_TEXT. When webservice servers validate the string, if the string contain more than TEXT, they fails the validation. The string can contain anything it does not have to be PARAM_TEXT.

            Note: at the end our web service servers validation process is an insurance for the web service developer that the function does not return any unexpected values. External clients still should validate all their input.

            Show
            jerome Jérôme Mouneyrac added a comment - Yes sorry. The string returned is declared as PARAM_TEXT. When webservice servers validate the string, if the string contain more than TEXT, they fails the validation. The string can contain anything it does not have to be PARAM_TEXT. Note: at the end our web service servers validation process is an insurance for the web service developer that the function does not return any unexpected values. External clients still should validate all their input.
            Hide
            poltawski Dan Poltawski added a comment -

            Integrated to 24 and master. Thanks

            Show
            poltawski Dan Poltawski added a comment - Integrated to 24 and master. Thanks
            Hide
            abgreeve Adrian Greeve added a comment -

            If the test is just to run the unit tests, then this test passes.
            Tested on master and 2.4.

            Show
            abgreeve Adrian Greeve added a comment - If the test is just to run the unit tests, then this test passes. Tested on master and 2.4.
            Hide
            poltawski Dan Poltawski added a comment -

            Hurray! We did it! Thanks to all the reporters, testers, user and watchers for a bumper week of Moodling!

            Show
            poltawski Dan Poltawski added a comment - Hurray! We did it! Thanks to all the reporters, testers, user and watchers for a bumper week of Moodling!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Mar/13