[MDL-37407] Windows Filenames in zip files disappear or turn to gibberish when unzipped in the Moodle bases on Linux - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.3, 2.4
Fix Version/s: 2.4.2
Component/s: Filepicker, Files API, Language
Labels:
- triaged

Affected Branches:
MOODLE_23_STABLE, MOODLE_24_STABLE
Fixed Branches:
MOODLE_24_STABLE
Pull from Repository:
git://github.com/skodak/moodle.git
Pull Master Branch:
w04_~~MDL-37407~~_m25_chineseunzip
Pull Master Diff URL:
https://github.com/skodak/moodle/compare/master...w04_MDL-37407_m25_chineseunzip
Testing Instructions:

Hide

1/ if you understand Chinese switch to zh_cn and unzip the attached 16.zip in Moodle
2/ alternatively open some filepicker and upload the 16.zip file, switch to other browser tab and select to zh_cn there, then switch back and extract the file (the point is to keep filepicker UI in English, but the ajax call in Chinese)

Show
1/ if you understand Chinese switch to zh_cn and unzip the attached 16.zip in Moodle 2/ alternatively open some filepicker and upload the 16.zip file, switch to other browser tab and select to zh_cn there, then switch back and extract the file (the point is to keep filepicker UI in English, but the ajax call in Chinese)

Description

Unzip a .zip file, which is created under Microsoft Windows, the double-byte character filename will disapper or turn to gibberish! See the screehshots.
This issue MDL-33068 has not fixed the problem.
More information:
Both of the files in the zip, and the zip file are created under MS Windows 7.
The Moodle 2.4 is base on CentOS

The problem was that attached file is not compatible with unicode and Moodle did not contain yet the necessary heuristics to detect encoding from Chinese selected as current language in Moodle.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

16.zip
0.3 kB
08/Jan/13 9:14 AM
a.zip
43 kB
21/Jan/13 10:54 AM
fixed_unzip.png
38 kB
13/Jan/13 7:49 PM
screenshot-1.jpg
39 kB
08/Jan/13 9:21 AM
screenshot-2.jpg
29 kB
08/Jan/13 9:22 AM

Issue Links

blocks

MDL-33068 Select filenames encoding on unzip

Closed

Activity

People

Assignee:: Petr Skoda

Reporter:: xaero

Integrator:: Sam Hemelryk

Tester:: Andrew Davis

Participants:: Andrew Davis, CiBoT, Dan Poltawski, Eloy Lafuente (stronk7), Frédéric Massart, Helen Foster, Marina Glancy, Petr Skoda, Sam Hemelryk, xaero

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, Matteo Scaramuccia, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 9 Start watching this issue

Dates

Created:: 08/Jan/13 9:12 AM

Updated:: 14/Dec/16 10:39 PM

Resolved:: 31/Jan/13 7:20 PM

Fix Release Date:: 11/Mar/13