Moodle
  1. Moodle
  2. MDL-37413

Incorrect use of overlay instead of panel in chooserdialogue

    Details

    • Testing Instructions:
      Hide
      • Navigate to the course page
      • Turn editing on
      • Open developer tools and look at HTML elements tab
      • Open the Activity chooser
        • Confirm that the activity chooser displays correctly
        • Confirm that a new DOM node was created as the last child in the body tag
      • Close the chooser and re-open
        • Confirm that it re-opens correctly
        • Confirm that no additional DOM nodes were created
        • Confirm that you can successfully use the chooser
      Show
      Navigate to the course page Turn editing on Open developer tools and look at HTML elements tab Open the Activity chooser Confirm that the activity chooser displays correctly Confirm that a new DOM node was created as the last child in the body tag Close the chooser and re-open Confirm that it re-opens correctly Confirm that no additional DOM nodes were created Confirm that you can successfully use the chooser
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull Master Branch:

      Description

      It looks like when overlay was converted to panel in MDL-30899, an instance was missed.
      This leads to additional instances of a chooser dialogue being created and not destroyed each time it is opened.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Rajesh Taneja added a comment -

            Patch looks good Andrew.

            Please change MDl number in commit message before pushing it for integration. (currently it's MDL-37412)

            [y] Syntax
            [y] Output
            [y] Whitespace
            [-] Language
            [-] Databases
            [y] Testing
            [-] Security
            [-] Documentation
            [n] Git – (Wrong mdl in commit message)
            [y] Sanity check

            Show
            Rajesh Taneja added a comment - Patch looks good Andrew. Please change MDl number in commit message before pushing it for integration. (currently it's MDL-37412 ) [y] Syntax [y] Output [y] Whitespace [-] Language [-] Databases [y] Testing [-] Security [-] Documentation [n] Git – (Wrong mdl in commit message) [y] Sanity check
            Hide
            Andrew Nicols added a comment -

            Thanks for picking that up. I've pushed updated branches with the commit message fix.

            Show
            Andrew Nicols added a comment - Thanks for picking that up. I've pushed updated branches with the commit message fix.
            Hide
            Rajesh Taneja added a comment -

            Thanks Andrew.

            Show
            Rajesh Taneja added a comment - Thanks Andrew.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            Dan Poltawski added a comment -

            Adding David Mo here for his info about the 'regression'.

            Show
            Dan Poltawski added a comment - Adding David Mo here for his info about the 'regression'.
            Hide
            Dan Poltawski added a comment -

            Integrated to master, 24 and 23. thanks Andrew

            Show
            Dan Poltawski added a comment - Integrated to master, 24 and 23. thanks Andrew
            Hide
            David Monllaó added a comment -

            Thanks Dan and Andrew

            Show
            David Monllaó added a comment - Thanks Dan and Andrew
            Hide
            Andrew Davis added a comment -

            I'm still seeing a new instance being created each time in 2.3 and 2.4. Its working fine in master.

            Show
            Andrew Davis added a comment - I'm still seeing a new instance being created each time in 2.3 and 2.4. Its working fine in master.
            Hide
            Andrew Davis added a comment -

            I'm not sure why this isn't working in 2.4 or 2.3 but it definitely isn't

            Show
            Andrew Davis added a comment - I'm not sure why this isn't working in 2.4 or 2.3 but it definitely isn't
            Hide
            Andrew Davis added a comment - - edited

            My mistake. I was pulling 2.4 and 2.3 from the wrong repository. It is actually working.

            I don't appear to have the capability to reset this. It can be reset and marked as passed.

            Show
            Andrew Davis added a comment - - edited My mistake. I was pulling 2.4 and 2.3 from the wrong repository. It is actually working. I don't appear to have the capability to reset this. It can be reset and marked as passed.
            Hide
            Dan Poltawski added a comment -

            Thanks Andrew, passing

            Show
            Dan Poltawski added a comment - Thanks Andrew, passing
            Hide
            Dan Poltawski added a comment -

            Hurray! We did it! Thanks to all the reporters, testers, user and watchers for a bumper week of Moodling!

            Show
            Dan Poltawski added a comment - Hurray! We did it! Thanks to all the reporters, testers, user and watchers for a bumper week of Moodling!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: