Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37413

Incorrect use of overlay instead of panel in chooserdialogue

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      • Navigate to the course page
      • Turn editing on
      • Open developer tools and look at HTML elements tab
      • Open the Activity chooser
        • Confirm that the activity chooser displays correctly
        • Confirm that a new DOM node was created as the last child in the body tag
      • Close the chooser and re-open
        • Confirm that it re-opens correctly
        • Confirm that no additional DOM nodes were created
        • Confirm that you can successfully use the chooser
      Show
      Navigate to the course page Turn editing on Open developer tools and look at HTML elements tab Open the Activity chooser Confirm that the activity chooser displays correctly Confirm that a new DOM node was created as the last child in the body tag Close the chooser and re-open Confirm that it re-opens correctly Confirm that no additional DOM nodes were created Confirm that you can successfully use the chooser
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull Master Branch:

      Description

      It looks like when overlay was converted to panel in MDL-30899, an instance was missed.
      This leads to additional instances of a chooser dialogue being created and not destroyed each time it is opened.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Mar/13