Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.5
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      Check that the activity chooser still works.
      In Firefox, Chrome and IE browsers:

      There should be no actual changes other than to fix incorrect syntax which may improve some browser compatibility.

      Also, run jshint (available from Node.js) over lib/yui/chooserdialogue/chooserdialogue.js for each branch

      Show
      Check that the activity chooser still works. In Firefox, Chrome and IE browsers: There should be no actual changes other than to fix incorrect syntax which may improve some browser compatibility. Also, run jshint (available from Node.js) over lib/yui/chooserdialogue/chooserdialogue.js for each branch
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:

      Description

      I'm planning some work on the chooser dialogue at the moment, and it would be great if it validated correctly first...

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              damyon Damyon Wiese added a comment -

              Thanks Andrew,

              This patch looks good to me.

              Sending for integration review.

              Show
              damyon Damyon Wiese added a comment - Thanks Andrew, This patch looks good to me. Sending for integration review.
              Hide
              damyon Damyon Wiese added a comment -

              Just adding a subset of browsers to the testing instructions (this is a low risk change).

              Show
              damyon Damyon Wiese added a comment - Just adding a subset of browsers to the testing instructions (this is a low risk change).
              Hide
              damyon Damyon Wiese added a comment -

              Also - this is an improvement and should not be backported.

              Show
              damyon Damyon Wiese added a comment - Also - this is an improvement and should not be backported.
              Hide
              dobedobedoh Andrew Nicols added a comment -

              Part of me would argue that this should be backported as some of the changes made are to fix issues with browser compatibility (e.g. IE sucks at trailing commas). That said, none of the issues I've addressed so far have been for an extra ,

              Show
              dobedobedoh Andrew Nicols added a comment - Part of me would argue that this should be backported as some of the changes made are to fix issues with browser compatibility (e.g. IE sucks at trailing commas). That said, none of the issues I've addressed so far have been for an extra ,
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              TIA and ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              poltawski Dan Poltawski added a comment -

              I'm on the fence about backporting it (epsecially as its hard for us to prove that there was a problem before in normal use). If there were JS warnings I would be more convinced.

              Show
              poltawski Dan Poltawski added a comment - I'm on the fence about backporting it (epsecially as its hard for us to prove that there was a problem before in normal use). If there were JS warnings I would be more convinced.
              Hide
              poltawski Dan Poltawski added a comment -

              I missed Damyons comment, thats enough confirmation for me. This will go into master only.

              Show
              poltawski Dan Poltawski added a comment - I missed Damyons comment, thats enough confirmation for me. This will go into master only.
              Hide
              poltawski Dan Poltawski added a comment -

              Integrated to master only, thanks Andrew.

              Show
              poltawski Dan Poltawski added a comment - Integrated to master only, thanks Andrew.
              Hide
              salvetore Michael de Raadt added a comment -

              Test result: Success!

              Tested in Master only.

              JSHint revealed no warnings.

              Testing in IE10, FF18, Chrome23 and Safari5 showed no JS errors.

              Show
              salvetore Michael de Raadt added a comment - Test result: Success! Tested in Master only. JSHint revealed no warnings. Testing in IE10, FF18, Chrome23 and Safari5 showed no JS errors.
              Hide
              poltawski Dan Poltawski added a comment -

              Hurray! We did it! Thanks to all the reporters, testers, user and watchers for a bumper week of Moodling!

              Show
              poltawski Dan Poltawski added a comment - Hurray! We did it! Thanks to all the reporters, testers, user and watchers for a bumper week of Moodling!

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    14/May/13