Moodle
  1. Moodle
  2. MDL-37417 Question editing forms improvements
  3. MDL-37422

Quiz: Group fields related to 'Settings for multiple tries.'

        Details

        • Testing Instructions:
          Hide

          Create questions of the following type:

          1. truefalse
          2. shortanswer
          3. matching.

          Focus on the 'Multiple tries' part of the form, which should now be a single section of the form.

          A. Make sure the arragement of form fields looks good.
          B. Verify that Create / Edit operations work. That is, the question definition is saved correctly, without any errors.

          Show
          Create questions of the following type: 1. truefalse 2. shortanswer 3. matching. Focus on the 'Multiple tries' part of the form, which should now be a single section of the form. A. Make sure the arragement of form fields looks good. B. Verify that Create / Edit operations work. That is, the question definition is saved correctly, without any errors.
        • Affected Branches:
          MOODLE_24_STABLE
        • Fixed Branches:
          MOODLE_25_STABLE
        • Pull from Repository:
        • Pull Master Branch:
        • Pull Master Diff URL:

          Description

          I think this refers to question types that have both "Show num parts correct" and "Clear incorrect". These can be on the same line.

            Gliffy Diagrams

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Colin Chambers added a comment - - edited

              Fixed. Committed and pushed to master

              Show
              Colin Chambers added a comment - - edited Fixed. Committed and pushed to master
              Hide
              Permalink
              Colin Chambers added a comment -

              No change to functionality. Just to layout.

              Show
              Colin Chambers added a comment - No change to functionality. Just to layout.
              Hide
              Permalink
              Tim Hunt added a comment -

              That looks good, although I think we can improve it a bit:

              1. $field_group breaks the coding style. No _ in variable names. Also, it think something like $optionelements is a more descriptive name.

              2. In the CSS, I think it would be better to do

                  #multitriesheader div.fitem_feditor {margin-top: 1em;}

              since that does not add extra space at the end of the section, and does separate the first hint from the penalty setting.

              3. I would combine the other two rules:

                  #multitriesheader div.fitem_fgroup fieldset.felement label {margin-left: 0.3em; margin-right: 0.3em;}

              Show
              Tim Hunt added a comment - That looks good, although I think we can improve it a bit: 1. $field_group breaks the coding style. No _ in variable names. Also, it think something like $optionelements is a more descriptive name. 2. In the CSS, I think it would be better to do #multitriesheader div.fitem_feditor {margin-top: 1em;} since that does not add extra space at the end of the section, and does separate the first hint from the penalty setting. 3. I would combine the other two rules: #multitriesheader div.fitem_fgroup fieldset.felement label {margin-left: 0.3em; margin-right: 0.3em;}
              Hide
              Permalink
              Colin Chambers added a comment -

              Thanks tim. Good comments. Updated and pushed code. I'm a little embarrassed about #3. Can't believe I missed that. Doh!!!

              re #2 I've added your line but kept my original too. e.g. margin at top and bottom of each hint group. Positions the add more button better IMO.

              Show
              Colin Chambers added a comment - Thanks tim. Good comments. Updated and pushed code. I'm a little embarrassed about #3. Can't believe I missed that. Doh!!! re #2 I've added your line but kept my original too. e.g. margin at top and bottom of each hint group. Positions the add more button better IMO.
              Hide
              Permalink
              Colin Chambers added a comment -

              Addressed your last comments. HOpefully now it's good to go.

              Show
              Colin Chambers added a comment - Addressed your last comments. HOpefully now it's good to go.
              Hide
              Permalink
              Tim Hunt added a comment -

              Thanks Colin. That looks great now. Submitting for integration.

              Show
              Tim Hunt added a comment - Thanks Colin. That looks great now. Submitting for integration.
              Hide
              Permalink
              Eloy Lafuente (stronk7) added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              TIA and ciao

              Show
              Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              Permalink
              Colin Chambers added a comment -

              Thanks Eloy. Done. MDL-37422 now up to date with master

              Show
              Colin Chambers added a comment - Thanks Eloy. Done. MDL-37422 now up to date with master
              Hide
              Permalink
              Dan Poltawski added a comment -

              Integrated to master, thanks Colin!

              Show
              Dan Poltawski added a comment - Integrated to master, thanks Colin!
              Hide
              Permalink
              Adrian Greeve added a comment -

              Tested on the master integration branch.
              The arrangement of form looks fine and the create / edit operations are working.
              Test passed.

              Show
              Adrian Greeve added a comment - Tested on the master integration branch. The arrangement of form looks fine and the create / edit operations are working. Test passed.
              Hide
              Permalink
              Damyon Wiese added a comment -

              Congratulations! This issue has been resolved. Thanks for helping to make Moodle better for everyone!

              Regards, Damyon

              Show
              Damyon Wiese added a comment - Congratulations! This issue has been resolved. Thanks for helping to make Moodle better for everyone! Regards, Damyon

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: