Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-37429

rework file zipper debugging change from MDL-37429

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.5
    • Component/s: Unit tests

      Description

      The function assertDebuggingCalled() only expects one debugging message, where as a function can eventually send out more messages. We need to add some support for that.
      Please fix lib/filestorage/tests/zip_packer_test.php around line 151 (look for TODO MDL-37429) with this issue.


      The patch includes change of file packer API, the archive functions now include a new parameter that specifies what to do when file is invalid or missing. The zip packer may also create empty zip archive and later add files to it. All the new functionality is tested by unit tests. At the same time all obsolete hacks for PHP 5.2 were removed.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              skodak Petr Skoda
              Reporter:
              fred Frédéric Massart
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Mark Nelson
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/May/13