Moodle
  1. Moodle
  2. MDL-37455

Allow mod_folder to display the content inline on course page instead of on separate page

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.5
    • Component/s: Resource
    • Labels:
    • Testing Instructions:
      Hide
      1. Add folder resource to a course, select option "display inline on a course page"
      2. Try doing different actions with this folder - editing, duplicating, viewing by different users, changing visibility (also with "display greyed out"), conditional availability, completion status.
      3. Make sure there are no errors and folder is displayed/not displayed as expected. Note that most of the reports will not show records for the inline folder as well as they don't show records for labels

      Note that core changes were required for this issue, see also testing instructions for MDL-33774

      Show
      Add folder resource to a course, select option "display inline on a course page" Try doing different actions with this folder - editing, duplicating, viewing by different users, changing visibility (also with "display greyed out"), conditional availability, completion status. Make sure there are no errors and folder is displayed/not displayed as expected. Note that most of the reports will not show records for the inline folder as well as they don't show records for labels Note that core changes were required for this issue, see also testing instructions for MDL-33774
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
      wip-MDL-37455-master
    • Rank:
      47091

      Description

      Inspired by MDL-37416. But instead of course format to say how to display content, this should be a module option.

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment -

          That sounds really interesting.

          Show
          Michael de Raadt added a comment - That sounds really interesting.
          Hide
          Andrew Nicols added a comment - - edited

          I really like this as a feature. I've not got time to do a complete peer review now so I'll leave that for someone else.

          Only comment I have so far is that the 'Edit' button is still shown (for an appropriate user) even when course editing is turned off (and I don't think that it should).

          Andrew

          Show
          Andrew Nicols added a comment - - edited I really like this as a feature. I've not got time to do a complete peer review now so I'll leave that for someone else. Only comment I have so far is that the 'Edit' button is still shown (for an appropriate user) even when course editing is turned off (and I don't think that it should). Andrew
          Hide
          Ray Lawrence added a comment -

          Performance: Will this slow pages to a crawl? We don't need anything else that does that atm.

          Show
          Ray Lawrence added a comment - Performance: Will this slow pages to a crawl? We don't need anything else that does that atm.
          Hide
          Ray Lawrence added a comment -

          Btw, I like this as an option.

          Show
          Ray Lawrence added a comment - Btw, I like this as an option.
          Hide
          Marina Glancy added a comment -

          Ray, it IS an option and default is still displaying the folder on a separate page.
          Yes it may slow course view page IF folder contains a lot of external shortcuts or contains too many files. But I hope that people who design the course can understand it.

          Show
          Marina Glancy added a comment - Ray, it IS an option and default is still displaying the folder on a separate page. Yes it may slow course view page IF folder contains a lot of external shortcuts or contains too many files. But I hope that people who design the course can understand it.
          Hide
          Marina Glancy added a comment -

          Ray, thanks, you made me think about two additional DB queries that could be avoided. I added a commit that eliminates them by caching some folder data

          Show
          Marina Glancy added a comment - Ray, thanks, you made me think about two additional DB queries that could be avoided. I added a commit that eliminates them by caching some folder data
          Hide
          Marina Glancy added a comment -

          PS I did not write an upgrade script, if anybody has already played with this branch please edit any module inside the course so course cache gets rebuilt.

          Show
          Marina Glancy added a comment - PS I did not write an upgrade script, if anybody has already played with this branch please edit any module inside the course so course cache gets rebuilt.
          Hide
          Ray Lawrence added a comment -

          That's great thanks.

          Some may, others may not. May I suggest that the potential issue is highlighted in a help file for the option.

          Show
          Ray Lawrence added a comment - That's great thanks. Some may, others may not. May I suggest that the potential issue is highlighted in a help file for the option.
          Hide
          Andrew Nicols added a comment -

          It may be worth checking the client-side performance changes too, particularly with IE < 9. Adding the folder contents to the display will add calls to the YUI2 treeview so there is a potential performance hit here.

          Show
          Andrew Nicols added a comment - It may be worth checking the client-side performance changes too, particularly with IE < 9. Adding the folder contents to the display will add calls to the YUI2 treeview so there is a potential performance hit here.
          Hide
          Mary Cooch added a comment -

          I do like this as well, very much, although I can see overuse of it , not only slowing the page down but potentially adding to the "scroll of death" that using folders instead of individual files is meant to avoid! So carefully phrased help files, documentation (and training) will be needed.

          Show
          Mary Cooch added a comment - I do like this as well, very much, although I can see overuse of it , not only slowing the page down but potentially adding to the "scroll of death" that using folders instead of individual files is meant to avoid! So carefully phrased help files, documentation (and training) will be needed.
          Hide
          Gareth J Barnard added a comment -

          Could there be a setting globally that admin's set that enforced a maximum number of folders that are displayed inline on a course page? Thereby putting a break on users as I know from bitter experience that even with carefully phrased supporting documentation (which is worthwhile and users complain when it's not there) that users will still do what you don't want them to do and bad course design bad practice creeps in. Perhaps when the 'break' is enforced then users are directed to the help etc. which justifies why the break is there with good and bad examples of course design.

          Cheers,

          Gareth

          Show
          Gareth J Barnard added a comment - Could there be a setting globally that admin's set that enforced a maximum number of folders that are displayed inline on a course page? Thereby putting a break on users as I know from bitter experience that even with carefully phrased supporting documentation (which is worthwhile and users complain when it's not there) that users will still do what you don't want them to do and bad course design bad practice creeps in. Perhaps when the 'break' is enforced then users are directed to the help etc. which justifies why the break is there with good and bad examples of course design. Cheers, Gareth
          Hide
          Mary Cooch added a comment -

          I like that idea! I hope it is possible. It would teach the teachers something when (for example) they are stuck at displaying 10 files and they discover it is because the admin set a maximum - and they are told why. Except I can see in the future people requesting the option to change the default on a per -course basis, thus negating the point of restricting it in the first place.

          Show
          Mary Cooch added a comment - I like that idea! I hope it is possible. It would teach the teachers something when (for example) they are stuck at displaying 10 files and they discover it is because the admin set a maximum - and they are told why. Except I can see in the future people requesting the option to change the default on a per -course basis, thus negating the point of restricting it in the first place.
          Hide
          Gareth J Barnard added a comment -

          But if there was a per course basis then have a restriction that it can be the global maximum or less. And if the global maximum changes, so the course get lowered. In the situation of restoring courses with say ten inline but the global maximum is five, then the last five have their setting changed from inline. There is no actual loss of data as it's a display setting.

          However, if a request did happen in the future, refer the request to this tracker or put an anticipated 'why' in the help that such a feature will not be implemented because.... type thing.

          Show
          Gareth J Barnard added a comment - But if there was a per course basis then have a restriction that it can be the global maximum or less. And if the global maximum changes, so the course get lowered. In the situation of restoring courses with say ten inline but the global maximum is five, then the last five have their setting changed from inline. There is no actual loss of data as it's a display setting. However, if a request did happen in the future, refer the request to this tracker or put an anticipated 'why' in the help that such a feature will not be implemented because.... type thing.
          Hide
          Ray Lawrence added a comment -

          Just a small thought: The Display description option.

          The text is displayed below the list of files, that will look odd IMO.

          A good time to set up a related request for that setting to have the option to display above the resource link.... . I can re-kindle that issue if there's support here.

          Show
          Ray Lawrence added a comment - Just a small thought: The Display description option. The text is displayed below the list of files, that will look odd IMO. A good time to set up a related request for that setting to have the option to display above the resource link.... . I can re-kindle that issue if there's support here.
          Hide
          Marina Glancy added a comment - - edited

          I don't agree with restricting the number of folders or number of files. All situations are different. Don't forget as well that there are now many multiple-page course formats available. I would just add a warning on module edit page that too many courses displayed inline may slow the page loading.

          Ray, sorry did not quite understand which page you are talking about in your last comment

          Show
          Marina Glancy added a comment - - edited I don't agree with restricting the number of folders or number of files. All situations are different. Don't forget as well that there are now many multiple-page course formats available. I would just add a warning on module edit page that too many courses displayed inline may slow the page loading. Ray, sorry did not quite understand which page you are talking about in your last comment
          Hide
          Frédéric Massart added a comment -

          Hi Marina, great new option, I like it a lot. Please find my comments below:

          1. Not a big deal, but do you think the length of the display field should be 4 when specifically only 2 options are possible, and their value is 1 or 2. I've noticed that such fields are usually length 0 or 1.
          2. mod/folder/edit.php:55 Is that required to check if $folder->display is set? It should be set, and checking if !empty() is like doing == FOLDER_DISPLAY_PAGE, which can be confusing.
          3. It does not appear as we're concatenating strings in language files. I think it's safe to have one big line, or multilines without concatenation if need be.
          4. mod/folder/lib.php:436 The class name should end with ().
          5. mod/folder/lib.php:439 Is it required not to set introformat when FORMAT_MOODLE? From the look of it, an undefined property notice will popup in format_module_intro.
          6. mod/folder/lib.php:443 Can you comment on the use of jsen_encode instead of something else (serialise?)? Or even just using an object there?
          7. mod/folder/lib.php:462 Do you think that would make more sense to compare with display that you could set in customdata? I'm not a fan of comparing variables which do not appear related to the condition. As in "Why would customdata change the link status?".
          8. mod/folder/lib.php:475 Same as above, why is customdata linked to the info view?
          9. mod/folder/module.js Can you confirm it's safe to insert that parameter there instead of adding it after expand_all?
          10. mod/folder/renderer.php:40-41 Could you just fetch the required instance instead of all of them? The if is quite hard to read and you would easily miss the variable set in there. Also note that $context will never be false as context_module::instance() will throw an exception.
          11. mod/folder/renderer.php:78 You could make use of html_writer here.

          General

          • The new methods/functions should have @return void to their definitions so that we don't have to scroll to their end to make sure it does not return anything.
          • The comments should start with a capital letter and end with punctuation.
          • My personal preference when a function returns an int is to not assume that 0 == false, as in if (strlen()), I'd compare it to > 0. I feel like it's easier to read "If the length is greater than 0", rather than "If the length is true". Though it's just me.
          • On the same line, when using constants like FOLDER_DISPLAY_INLINE, I prefer === comparison, especially when the values include 0. But again, that's just me.
          • I think you can safely remove the 'edit' button from the course page, as it is easily mistaken with the module 'edit' option. Also, editing a folder content is possible by clicking the 'edit' icon.

          Many thanks!
          Fred

          Show
          Frédéric Massart added a comment - Hi Marina, great new option, I like it a lot. Please find my comments below: Not a big deal, but do you think the length of the display field should be 4 when specifically only 2 options are possible, and their value is 1 or 2. I've noticed that such fields are usually length 0 or 1. mod/folder/edit.php:55 Is that required to check if $folder->display is set? It should be set, and checking if !empty() is like doing == FOLDER_DISPLAY_PAGE, which can be confusing. It does not appear as we're concatenating strings in language files. I think it's safe to have one big line, or multilines without concatenation if need be. mod/folder/lib.php:436 The class name should end with (). mod/folder/lib.php:439 Is it required not to set introformat when FORMAT_MOODLE? From the look of it, an undefined property notice will popup in format_module_intro . mod/folder/lib.php:443 Can you comment on the use of jsen_encode instead of something else (serialise?)? Or even just using an object there? mod/folder/lib.php:462 Do you think that would make more sense to compare with display that you could set in customdata? I'm not a fan of comparing variables which do not appear related to the condition. As in "Why would customdata change the link status?". mod/folder/lib.php:475 Same as above, why is customdata linked to the info view? mod/folder/module.js Can you confirm it's safe to insert that parameter there instead of adding it after expand_all ? mod/folder/renderer.php:40-41 Could you just fetch the required instance instead of all of them? The if is quite hard to read and you would easily miss the variable set in there. Also note that $context will never be false as context_module::instance() will throw an exception. mod/folder/renderer.php:78 You could make use of html_writer here. General The new methods/functions should have @return void to their definitions so that we don't have to scroll to their end to make sure it does not return anything. The comments should start with a capital letter and end with punctuation. My personal preference when a function returns an int is to not assume that 0 == false, as in if (strlen()) , I'd compare it to > 0 . I feel like it's easier to read "If the length is greater than 0", rather than "If the length is true". Though it's just me. On the same line, when using constants like FOLDER_DISPLAY_INLINE, I prefer === comparison, especially when the values include 0. But again, that's just me. I think you can safely remove the 'edit' button from the course page, as it is easily mistaken with the module 'edit' option. Also, editing a folder content is possible by clicking the 'edit' icon. Many thanks! Fred
          Hide
          Ray Lawrence added a comment -

          I looked more closely at the screen shot - I see that the description text is above the file listing.

          Restricting file numbers: I don't feel that setting an arbitrary limit is the way on this. It will cause issue where user use too many files, but setting a limit will probably frustrate more users.

          Show
          Ray Lawrence added a comment - I looked more closely at the screen shot - I see that the description text is above the file listing. Restricting file numbers: I don't feel that setting an arbitrary limit is the way on this. It will cause issue where user use too many files, but setting a limit will probably frustrate more users.
          Hide
          Marina Glancy added a comment -

          Fred, answering your comments

          1. I copied it from mod_resource. I leave a chance here for other possible folder display types, so they don't require DB changes. I can already think of the display type when tree is collapsed by default (in both inline and normal mode)
          2,3: thanks, corrected
          4. I don't mind changing it but I thought that was the agreement - to skip () in stdClass. If you do "git grep 'new stdClass'" - it's a mixture
          5. This is cached object. The less information is cached the better, so we skip default values. If you look at folder_cm_info_view() - before we display the object we restore defaults.
          6. Yes you are right, no encoding/serialising is actually necessary
          7,8. The reason is - customdata is filled IF AND ONLY IF displaytype is not 0. Otherwise (i.e. in the most cases) we don't cache extra information and don't decrease performance by this patch. But I added comments about it
          9. yes, it's safe. This is a javascript file inside a plugin, it can not (= should not) be used by anything outside the plugin.
          10. No, I can't fetch the instance other way. Do you have a better solution? I know that context is never a null, this is just an assignment to use $context in the next if clause (so I don't have to write several nested if's).
          11. hehe, I know but I did not improve this part of code. I have just changed "echo " to "$output .= "

          Show
          Marina Glancy added a comment - Fred, answering your comments 1. I copied it from mod_resource. I leave a chance here for other possible folder display types, so they don't require DB changes. I can already think of the display type when tree is collapsed by default (in both inline and normal mode) 2,3: thanks, corrected 4. I don't mind changing it but I thought that was the agreement - to skip () in stdClass. If you do "git grep 'new stdClass'" - it's a mixture 5. This is cached object. The less information is cached the better, so we skip default values. If you look at folder_cm_info_view() - before we display the object we restore defaults. 6. Yes you are right, no encoding/serialising is actually necessary 7,8. The reason is - customdata is filled IF AND ONLY IF displaytype is not 0. Otherwise (i.e. in the most cases) we don't cache extra information and don't decrease performance by this patch. But I added comments about it 9. yes, it's safe. This is a javascript file inside a plugin, it can not (= should not) be used by anything outside the plugin. 10. No, I can't fetch the instance other way. Do you have a better solution? I know that context is never a null, this is just an assignment to use $context in the next if clause (so I don't have to write several nested if's). 11. hehe, I know but I did not improve this part of code. I have just changed "echo " to "$output .= "
          Hide
          Dan Poltawski added a comment -

          Hi Marina,

          This is a cool feature.

          Looking at it though, my main concern is that we're using customdata rather than using MUC for caching. This feels like exactly the sort of use case which MUC was designed for, so can you justify why we're not using it?

          Some other comments:

          • 4. I don't mind changing it but I thought that was the agreement - to skip () in stdClass. If you do "git grep 'new stdClass'" - it's a mixture

            Its not, its Sam Hemelryk's bad habbit I think :-P. If its not in the coding style its not gospel:
            http://docs.moodle.org/dev/Coding_style#Classes

          • We should test this with all the other crazy course page ajax features
          • I dislike really long chained if statements, just FYI :-P

          thanks,
          Dan

          Show
          Dan Poltawski added a comment - Hi Marina, This is a cool feature. Looking at it though, my main concern is that we're using customdata rather than using MUC for caching. This feels like exactly the sort of use case which MUC was designed for, so can you justify why we're not using it? Some other comments: 4. I don't mind changing it but I thought that was the agreement - to skip () in stdClass. If you do "git grep 'new stdClass'" - it's a mixture Its not, its Sam Hemelryk's bad habbit I think :-P. If its not in the coding style its not gospel: http://docs.moodle.org/dev/Coding_style#Classes We should test this with all the other crazy course page ajax features I dislike really long chained if statements, just FYI :-P thanks, Dan
          Hide
          Marina Glancy added a comment -

          Hi Dan, do you want me to add a commit changing "new stdClass" to "new stdClass()" ?
          Re customdata - this is the way the modules information is prepared to be stored in course.modinfo. The whole course.modinfo should be better cached in MUC but that's another story. Or I did not understand what you meant

          Show
          Marina Glancy added a comment - Hi Dan, do you want me to add a commit changing "new stdClass" to "new stdClass()" ? Re customdata - this is the way the modules information is prepared to be stored in course.modinfo. The whole course.modinfo should be better cached in MUC but that's another story. Or I did not understand what you meant
          Hide
          Dan Poltawski added a comment -

          Hi Marina,

          Yep, good point, it makes perfect sense. But i'm going to have to leave this one for this week because its now wednesday.

          If you can change the stdClass it would be great.

          Show
          Dan Poltawski added a comment - Hi Marina, Yep, good point, it makes perfect sense. But i'm going to have to leave this one for this week because its now wednesday. If you can change the stdClass it would be great.
          Hide
          Marina Glancy added a comment -

          ok, corrected stdClass

          Show
          Marina Glancy added a comment - ok, corrected stdClass
          Hide
          Dan Poltawski added a comment -

          Integrated to master - thanks Marina!

          Show
          Dan Poltawski added a comment - Integrated to master - thanks Marina!
          Hide
          Dan Poltawski added a comment -

          Hmm. I see that the edit button is still there on the course apge, despite the two comments about this from Andrew and Fred?

          Show
          Dan Poltawski added a comment - Hmm. I see that the edit button is still there on the course apge, despite the two comments about this from Andrew and Fred?
          Hide
          Marina Glancy added a comment -

          Dan, edit button has always been there. There is even a separate page in mod_folder that opens a form for edit module but only with files field. I can create another issue to remove this button but (as usual) I foresee complaints from users who got used to it.

          At least I put this button in renderer now

          Show
          Marina Glancy added a comment - Dan, edit button has always been there. There is even a separate page in mod_folder that opens a form for edit module but only with files field. I can create another issue to remove this button but (as usual) I foresee complaints from users who got used to it. At least I put this button in renderer now
          Hide
          Dan Poltawski added a comment -

          Marina - its not always been on the course page has it?

          On the course page when you've got editing off that edit button does not look right (I agree with Fred, we should not have the edit button on the course page at all, just on the module edit page).

          Show
          Dan Poltawski added a comment - Marina - its not always been on the course page has it? On the course page when you've got editing off that edit button does not look right (I agree with Fred, we should not have the edit button on the course page at all, just on the module edit page).
          Hide
          Eloy Lafuente (stronk7) added a comment -

          FYI, just upgraded to current integration.git, visited my site (not logged) and got:

          Debug info: Unknown column 'display' in 'field list'
          SELECT id, name, display, intro, introformat FROM mdl_folder WHERE id = ?
          [array (
          0 => '1',
          )]
          Error code: dmlreadexception
          Stack trace:
          line 426 of /lib/dml/moodle_database.php: dml_read_exception thrown
          line 1005 of /lib/dml/mysqli_native_moodle_database.php: call to moodle_database->query_end()
          line 1401 of /lib/dml/moodle_database.php: call to mysqli_native_moodle_database->get_records_sql()
          line 1373 of /lib/dml/moodle_database.php: call to moodle_database->get_record_sql()
          line 1352 of /lib/dml/moodle_database.php: call to moodle_database->get_record_select()
          line 429 of /mod/folder/lib.php: call to moodle_database->get_record()
          line 936 of /course/lib.php: call to folder_get_coursemodule_info()
          line 1457 of /lib/modinfolib.php: call to get_array_of_activities()
          line 249 of /lib/modinfolib.php: call to rebuild_course_cache()
          line 1393 of /lib/modinfolib.php: call to course_modinfo->__construct()
          line 54 of /filter/activitynames/filter.php: call to get_fast_modinfo()
          line 167 of /lib/filterlib.php: call to filter_activitynames->filter()
          line 205 of /lib/filterlib.php: call to filter_manager->apply_filter_chain()
          line 337 of /lib/filterlib.php: call to filter_manager->filter_text()
          line 1137 of /lib/weblib.php: call to performance_measuring_filter_manager->filter_text()
          line 1816 of /course/lib.php: call to format_text()
          line 1701 of /course/lib.php: call to print_course()
          line 230 of /index.php: call to print_courses()

          ... logging in was possible and upgrading fixed it... just guessing if we should perform an impeding upgrade here (or it not necessary if logging in is possible).

          FYC, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - FYI, just upgraded to current integration.git, visited my site (not logged) and got: Debug info: Unknown column 'display' in 'field list' SELECT id, name, display, intro, introformat FROM mdl_folder WHERE id = ? [array ( 0 => '1', )] Error code: dmlreadexception Stack trace: line 426 of /lib/dml/moodle_database.php: dml_read_exception thrown line 1005 of /lib/dml/mysqli_native_moodle_database.php: call to moodle_database->query_end() line 1401 of /lib/dml/moodle_database.php: call to mysqli_native_moodle_database->get_records_sql() line 1373 of /lib/dml/moodle_database.php: call to moodle_database->get_record_sql() line 1352 of /lib/dml/moodle_database.php: call to moodle_database->get_record_select() line 429 of /mod/folder/lib.php: call to moodle_database->get_record() line 936 of /course/lib.php: call to folder_get_coursemodule_info() line 1457 of /lib/modinfolib.php: call to get_array_of_activities() line 249 of /lib/modinfolib.php: call to rebuild_course_cache() line 1393 of /lib/modinfolib.php: call to course_modinfo->__construct() line 54 of /filter/activitynames/filter.php: call to get_fast_modinfo() line 167 of /lib/filterlib.php: call to filter_activitynames->filter() line 205 of /lib/filterlib.php: call to filter_manager->apply_filter_chain() line 337 of /lib/filterlib.php: call to filter_manager->filter_text() line 1137 of /lib/weblib.php: call to performance_measuring_filter_manager->filter_text() line 1816 of /course/lib.php: call to format_text() line 1701 of /course/lib.php: call to print_course() line 230 of /index.php: call to print_courses() ... logging in was possible and upgrading fixed it... just guessing if we should perform an impeding upgrade here (or it not necessary if logging in is possible). FYC, ciao
          Hide
          Marina Glancy added a comment - - edited

          removed comment (ups, I should have read more carefully. This is different part of code. Sorry Fred )

          Show
          Marina Glancy added a comment - - edited removed comment (ups, I should have read more carefully. This is different part of code. Sorry Fred )
          Hide
          Marina Glancy added a comment -

          Re Eloy comment: this is master only, so for real users this will be part of upgrade from 2.4 to 2.5, in which case it won't be an issue. But we can force upgrade here if integrators decide to

          Show
          Marina Glancy added a comment - Re Eloy comment: this is master only, so for real users this will be part of upgrade from 2.4 to 2.5, in which case it won't be an issue. But we can force upgrade here if integrators decide to
          Hide
          Dan Poltawski added a comment -

          Marina: it will be an issue because Moodle is expected to work even if the admin hasn't run the upgrade (i.e. the front page should continue to work). You can use redirect_if_major_update_required() to prevent this.

          I've added a commit doing this.

          Show
          Dan Poltawski added a comment - Marina: it will be an issue because Moodle is expected to work even if the admin hasn't run the upgrade (i.e. the front page should continue to work). You can use redirect_if_major_update_required() to prevent this. I've added a commit doing this.
          Hide
          David Monllaó added a comment - - edited

          It passes, the only thing is with completion enabled, the completion button in the left side overlaps a bit the folder contents container.

          (Comment edited as I made a mistake with the move right)

          Show
          David Monllaó added a comment - - edited It passes, the only thing is with completion enabled, the completion button in the left side overlaps a bit the folder contents container. (Comment edited as I made a mistake with the move right)
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Because

          A
          MARVELOUS
          A       U
          Z  YOU  P
          I  ARE  E
          N  PPL  R
          G       B
            TNKS! 
          

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Because A MARVELOUS A U Z YOU P I ARE E N PPL R G B TNKS! Closing, ciao
          Hide
          Eloy Lafuente (stronk7) added a comment -

          100% offtopic, I was reading this because another, linked issue but, for the records... I'm 99% sure it's:

          stdClass()

          and not any other variant! Anyway... who cares.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - 100% offtopic, I was reading this because another, linked issue but, for the records... I'm 99% sure it's: stdClass() and not any other variant! Anyway... who cares. Ciao
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Note MDL-38634 has been created related with this.

          Show
          Eloy Lafuente (stronk7) added a comment - Note MDL-38634 has been created related with this.
          Hide
          Mary Cooch added a comment -

          Removing qa_test_required label as a test is now written for this ready for the next cycle of testing MDLQA-5252 (bearing in mind however MDL-38634 )

          Show
          Mary Cooch added a comment - Removing qa_test_required label as a test is now written for this ready for the next cycle of testing MDLQA-5252 (bearing in mind however MDL-38634 )
          Hide
          Mary Cooch added a comment -

          Removing docs_required label as this is now documented here http://docs.moodle.org/25/en/Folder_resource_settings

          Show
          Mary Cooch added a comment - Removing docs_required label as this is now documented here http://docs.moodle.org/25/en/Folder_resource_settings

            People

            • Votes:
              5 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: