Moodle

Combined feedback: Show the number of correct responses ticked by default

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.4
  • Fix Version/s: 2.5
  • Component/s: Questions
  • Labels:
  • Testing Instructions:
    Hide

    1. Created a new Matching question in the question bank. Verify that the Show number of parts correct setting in the combined feedback section is ticked by default.

    2. Saved question. Re-edit it, and verify that the box is still ticked.

    3. Uncheck the settings, save the question, and re-edit. Verify that the box is still unchecked.

    Show
    1. Created a new Matching question in the question bank. Verify that the Show number of parts correct setting in the combined feedback section is ticked by default. 2. Saved question. Re-edit it, and verify that the box is still ticked. 3. Uncheck the settings, save the question, and re-edit. Verify that the box is still unchecked.
  • Affected Branches:
    MOODLE_24_STABLE
  • Fixed Branches:
    MOODLE_25_STABLE
  • Pull from Repository:
  • Pull 2.4 Branch:
  • Pull 2.4 Diff URL:
  • Pull Master Branch:
  • Pull Master Diff URL:

Description

Combined feedback does not have "Show the number of correct responses" ticked but Drag and Drop into text and onto images do have it ticked and I like it. We should be consistent and tick the box when the form is new.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Colin Chambers added a comment -

Just added a default for combined feedback field shownumcorrect
line is
$mform->setDefault('shownumcorrect', true);

Confirmed expected functionality by:
Created a new Matching question. shownumcorrect default is now checked be default. Saved question. Opened it unchecked and saved. Reopened. field still unchecked.

Show
Colin Chambers added a comment - Just added a default for combined feedback field shownumcorrect line is $mform->setDefault('shownumcorrect', true); Confirmed expected functionality by: Created a new Matching question. shownumcorrect default is now checked be default. Saved question. Opened it unchecked and saved. Reopened. field still unchecked.
Hide
Permalink
Tim Hunt added a comment -

+1, thanks Colin. Submitting for integration.

Should this go into 2.4? I think it is a small improvement and it would do no harm to add it to 2.4. It really depends how strict the integrators want to be with the 'bug-fixes only in stable' policy.

(Colin, For future reference, it would be better if the first line of the commit comment was a bit shortere. If you look in github https://github.com/colchambers/moodle/compare/master...MDL-37465, try to avoid triggering the ... thing in github's display.)

Show
Tim Hunt added a comment - +1, thanks Colin. Submitting for integration. Should this go into 2.4? I think it is a small improvement and it would do no harm to add it to 2.4. It really depends how strict the integrators want to be with the 'bug-fixes only in stable' policy. (Colin, For future reference, it would be better if the first line of the commit comment was a bit shortere. If you look in github https://github.com/colchambers/moodle/compare/master...MDL-37465 , try to avoid triggering the ... thing in github's display.)
Hide
Permalink
Colin Chambers added a comment -

Rebased on latest master and pushed. Thanks for comments tim.

Show
Colin Chambers added a comment - Rebased on latest master and pushed. Thanks for comments tim.
Hide
Permalink
Colin Chambers added a comment -

Tried a shorter commit message. Fits but is it acceptable? You call.

Show
Colin Chambers added a comment - Tried a shorter commit message. Fits but is it acceptable? You call.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show
Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
Hide
Permalink
Tim Hunt added a comment -

Thanks Colin. That is better.

Show
Tim Hunt added a comment - Thanks Colin. That is better.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Integrated (master only), thanks!

I know it's a minor and safe change, but recently we have decided to become more seriously-rigid, so this cannot land to stables, sorry.

FYI, just some hours ago, the new "seriously-rigid" approach has been documented (after agreement by the iTeam) at:

http://docs.moodle.org/dev/Integration_Review#Process_for_requesting_a_non_bug-fix_backport

Thanks and ciao

Show
Eloy Lafuente (stronk7) added a comment - Integrated (master only), thanks! I know it's a minor and safe change, but recently we have decided to become more seriously-rigid, so this cannot land to stables, sorry. FYI, just some hours ago, the new "seriously-rigid" approach has been documented (after agreement by the iTeam) at: http://docs.moodle.org/dev/Integration_Review#Process_for_requesting_a_non_bug-fix_backport Thanks and ciao
Hide
Permalink
Michael de Raadt added a comment -

Test result: Success!

Tested in Master only.

Show
Michael de Raadt added a comment - Test result: Success! Tested in Master only.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

A brilliant future is awaiting us out there, better with your code. Let's look towards the future together, this is now closed.

(and won't be revisiting it unless some regression is found)

Thanks and ciao

Show
Eloy Lafuente (stronk7) added a comment - A brilliant future is awaiting us out there, better with your code. Let's look towards the future together, this is now closed. (and won't be revisiting it unless some regression is found) Thanks and ciao

People

Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: